patchFreeciv - Patches: patch #4149, Simplify pollution/fallout effect...

 
 
Show feedback again

patch #4149: Simplify pollution/fallout effect definitions

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 05 Sep 2013 08:15:45 PM UTC  
 
Category: rulesetsPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 08 Sep 2013 10:55:24 AM UTC, SVN revision 23313:

Simplify the Output_Tile_Punish_Pct effect definitions for pollution and fallout.

Requested by Marko Lindqvist

See patch #4149

(Browse SVN revision 23313)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Fri 06 Sep 2013 11:18:11 AM UTC, comment #2:

Unless anyone objects I'll apply the patch simplifying the definitions.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Thu 05 Sep 2013 09:09:46 PM UTC, comment #1:

> As the effect is same for each output type, I think it would be possible to have just one effect to apply all the output types

It is. When I wrote them I assumed separate effect definitions was wanted to make it easy for modders to set each value separately like they did before.

(file #18884)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Thu 05 Sep 2013 08:15:45 PM UTC, original submission:

All our rulesets have long list of pollution and fallout effects, one effect for each output type. As the effect is same for each output type, I think it would be possible to have just one effect to apply all the output types (to not have output type requirement at all).
Note that while there's output types that do not apply to tile (Tax/Lux/Science), "Output_Tile_Punish_Pct" effect is never checked for them (for the very reason that it checks for tile output).

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18884:  reduceOutputPunish.patch added by sveinung (20kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sveinung (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Sep 2013 10:56:51 AM UTCsveinungStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 06 Sep 2013 11:18:11 AM UTCsveinungStatusNone=>Ready For Test
      Assigned toNone=>sveinung
    Thu 05 Sep 2013 09:09:46 PM UTCsveinungAttached File-=>Added reduceOutputPunish.patch, #18884
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup