patchFreeciv - Patches: patch #4159, Add Inaccessible terrain to...

 
 
Show feedback again

patch #4159: Add Inaccessible terrain to supplied rulesets

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 07 Sep 2013 04:26:07 PM UTC  
 
Category: rulesetsPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 12 Sep 2013 08:06:15 PM UTC, SVN revision 23355:

Added Inaccessible terrain type to classic, multiplayer, experimental, civ2civ3, and
alien rulesets.

See patch #4159

(Browse SVN revision 23355)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 12 Sep 2013 08:05:39 PM UTC, SVN revision 23354:

Added Inaccessible terrain type to classic, multiplayer, experimental, civ2civ3, and
alien rulesets.

See patch #4159

(Browse SVN revision 23354)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 10 Sep 2013 07:19:12 AM UTC, comment #5:

- Fixed typo in gfx tag name

(file #18954)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 09 Sep 2013 07:13:38 PM UTC, comment #4:

- Renamed in Inaccessible.

(file #18944)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 08 Sep 2013 05:25:32 PM UTC, comment #3:

Having inaccessible area simply black would make it harder to tell if the area is simply unknown (not explored) or inaccessible.

> (Also, it occurs to me that "Inaccessible" would be a more
> idiomatic English name.)


Will fix that - thank you for being our native speaker :-)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 08 Sep 2013 02:46:44 PM UTC, comment #2:

Neat idea.

As regards appearance, how about making it entirely black with a hard edge, like the edge of the map is currently? So the end appearance is that of a non-rectangular map.

There would however be subtle UI differences between off-the-map and Unaccessible terrain -- it would get an overlay as if "show native tiles" was enabled, for instance. That can't be solved without code changes. Without that, perhaps it's best if it looks distinct from off-the-map.

(Also, it occurs to me that "Inaccessible" would be a more idiomatic English name.)

Jacob Nevins <jtn>
Project Administrator
Sun 08 Sep 2013 02:16:55 PM UTC, comment #1:

Add "Unaccessible" terrain to classic, multiplayer, experimental, civ2civ3, and alien rulesets. I don't see how including these to civ1/civ2 rulesets would hurt the compatibility, but left them out anyway.
Note that alien ruleset has "Tile_Workable" effects defined so that new terrain would get the effect only if explicitly added - so no changes to alien/effects.ruleset.

(file #18926)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 07 Sep 2013 04:26:07 PM UTC, original submission:

Add "Unaccessible" terrain type to supplied rulesets for scenario map authors to use. It will never appear in normal generated maps. No unit can enter the tile, nor can cities work it. One can use it to "shape" map (accessible area).

Attached is a patch version that adds it to classic ruleset only.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18944:  InaccessibleTerrain.patch added by cazfi (9kB - text/x-diff)
file #18914:  UnaccessibleTerrain.patch added by cazfi (2kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Sep 2013 08:06:57 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
      Planned Release2.6.0=>2.5.0, 2.6.0
    Tue 10 Sep 2013 07:19:12 AM UTCcazfiAttached File-=>Added InaccessibleTerrain-2.patch, #18954
    Mon 09 Sep 2013 07:13:38 PM UTCcazfiAttached File-=>Added InaccessibleTerrain.patch, #18944
    Mon 09 Sep 2013 10:23:12 AM UTCcazfiSummaryAdd Unaccessible terrain to supplied rulesets=>Add Inaccessible terrain to supplied rulesets
    Sun 08 Sep 2013 02:16:55 PM UTCcazfiAttached File-=>Added UnaccessibleTerrain-2.patch, #18926
      StatusIn Progress=>Ready For Test
    Sat 07 Sep 2013 04:26:07 PM UTCcazfiAttached File-=>Added UnaccessibleTerrain.patch, #18914
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup