patchFreeciv - Patches: patch #4170, Make it possible to allow...

 
 
Show feedback again

patch #4170: Make it possible to allow sabotaging (visible) units in cities

Submitted by:  Sveinung Kvilhaugsvik <sveinung>
Submitted on:  Tue 10 Sep 2013 04:01:25 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 Sep 2013 12:59:49 PM UTC, SVN revision 23446:

Make it possible to allow sabotaging (visible) units in cities in rulesets.

Relax the hard coded requirement on sabotaging a unit from that it can't be
in a city to that it has to be visible for the actor.

Keep the restriction against sabotaging an unit in a city in the bundled
rulesets.

See patch #4170

(Browse SVN revision 23446)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 17 Sep 2013 02:58:34 PM UTC, comment #2:

The requirement that the unit has to be seen is to avoid giving modified clients an advantage.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Mon 16 Sep 2013 06:14:14 PM UTC, comment #1:
  • A city is still hard coded to stop a bribe.
  • The restriction against sabotaging a unit in a city is moved to the rule set. Hard code that the target unit has to be visible to prevent giving modified clients an advantage.

(file #19011)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 10 Sep 2013 04:01:25 PM UTC, original submission:

It is not possible to do actions against units in cities. Document this fact for bribe unit. Move it to the rule set for sabotage unit.

This probably shouldn't go in before meta knowledge about if the client can see the units in a city is added.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sveinung (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Sep 2013 01:02:01 PM UTCsveinungStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Tue 17 Sep 2013 02:58:34 PM UTCsveinungStatusIn Progress=>Ready For Test
      SummarySpy actions vs units in cities=>Make it possible to allow sabotaging (visible) units in cities
    Tue 17 Sep 2013 02:30:47 PM UTCsveinungAttached File-=>Added action_vs_unit_in_city.patch, #19023
      Dependencies-=>Depends on patch #4194
    Mon 16 Sep 2013 11:18:47 PM UTCsveinungStatusReady For Test=>In Progress
    Mon 16 Sep 2013 06:14:14 PM UTCsveinungAttached File-=>Added action_vs_unit_in_city.patch, #19011
      StatusIn Progress=>Ready For Test
    Tue 10 Sep 2013 04:02:11 PM UTCsveinungDependencies-=>Depends on patch #4169
    Tue 10 Sep 2013 04:01:25 PM UTCsveinungAttached File-=>Added action_vs_unit_in_city.patch, #18959
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup