patchFreeciv - Patches: patch #4188, Conflicting...

 
 
Show feedback again

patch #4188: Conflicting "AutoOnCityCenter" extras

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 15 Sep 2013 07:06:29 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 11 Dec 2013 09:59:12 PM UTC, SVN revision 23852:

Do not add "AutoOnCityCenter" extra if there already is conflicting extra
on tile

See patch #4188

(Browse SVN revision 23852)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 11 Dec 2013 09:59:06 PM UTC, SVN revision 23851:

Do not add "AutoOnCityCenter" extra if there already is conflicting extra
on tile

See patch #4188

(Browse SVN revision 23851)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 08 Dec 2013 10:26:17 AM UTC, comment #2:

Patch.

Do not add "AutoOnCityCenter" extra if there already is conflicting extra on tile. That doesn't make the ruleset use-case I wanted possible, but is clear rule we can implement (and what other ruleset authors probably expect).
"AlwaysOnCityCenter" is not changed - the flag is stronger indication that extra should exist than conflict is to indicate that it shouldn't. I wonder if we should remove the existing conflicting extra, though, if it too doesn't have "AlwaysOnCityCenter" (With current behavior you can build such extras before "AlwaysOnCityCenter" becomes available, but not after as there would be conflict)

(file #19434, file #19435)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 13 Oct 2013 10:58:24 PM UTC, comment #1:

Affects 2.5 since there bases can conflict each other, and can have "AutoOnCityCenter" -flag.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 15 Sep 2013 07:06:29 PM UTC, original submission:

How should we handle two "AutoOnCityCenter" extras requirements simultaneously fulfilled, conflicting each other?

Ruleset modification I were about to make when I realize this would be a problem:
Instead of Maglev being built on top (and requiring) Railroad, it would replace one if present. The main reason for this is that build cost of Maglev would not depend on whether tile already has Railroad (no need to build Railroad + Maglev).
Ideally city centers should have Maglevs when required tech is known, and Railroad only when it can be built but Maglev cannot.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Dec 2013 09:59:25 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 08 Dec 2013 10:26:17 AM UTCcazfiAttached File-=>Added ConflictingAutoCityCenter.patch, #19434
      Attached File-=>Added ConflictingAutoCityCenter-S2_5.patch, #19435
      StatusNone=>Ready For Test
    Sun 13 Oct 2013 10:58:24 PM UTCcazfiCategoryNone=>general
      Planned Release2.6.0=>2.5.0, 2.6.0
    Sun 15 Sep 2013 07:18:31 PM UTCcazfiPlanned Release=>2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup