patchFreeciv - Patches: patch #4194, Add hard requirements to the...

 
 
Show feedback again

patch #4194: Add hard requirements to the action enablers.

Submitted by:  Sveinung Kvilhaugsvik <sveinung>
Submitted on:  Tue 17 Sep 2013 01:34:01 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 Sep 2013 12:36:13 PM UTC, SVN revision 23444:

Add hard requirements to the action enablers.

Some actions have hard requirements that can be expressed as normal
requirement vectors. Add those requirements to the enablers of the actions
that require them while loading the enablers from the ruleset.

The advantage of this design is that all the requirement vector data of an
action live in the same place. This makes the code simpler. A disadvantage
is that the hard requirements will be evaluated for each action enabler. If
many action enablers for each action should become common this design choice
should be reconsidered.

See patch #4194

(Browse SVN revision 23444)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 17 Sep 2013 01:34:01 PM UTC, original submission:

Some actions have hard requirements that can be expressed as normal requirement vectors. Add them while loading the actions enablers from the rule set in stead of defining separate requirement vectors for them.

The down side of this design is that the hard requirements will be evaluated for each action enabler. Reconsider this choice if many action enablers for each action should become common.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Digest:
   patch dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by sveinung (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Sep 2013 12:36:33 PM UTCsveinungStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Tue 17 Sep 2013 02:30:47 PM UTCsveinungDependencies-=>patch #4170 is dependent
    Tue 17 Sep 2013 02:27:52 PM UTCsveinungAttached File-=>Added action_hard_reqs_to_enablers.patch, #19022
      Dependencies-=>Depends on patch #4191
    Tue 17 Sep 2013 01:34:01 PM UTCsveinungAttached File-=>Added action_hard_reqs_to_enablers.patch, #19021
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup