patchFreeciv - Patches: patch #4274, Reverting S2_5 packet type field...

 
 
Show feedback again

patch #4274: Reverting S2_5 packet type field to 8bit

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 26 Oct 2013 08:47:32 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0-beta1

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 11 Dec 2013 05:42:03 AM UTC, SVN revision 23849:

Made S2_5 packet type field 8 bits wide again.

See patch #4274

(Browse SVN revision 23849)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 07 Dec 2013 10:51:42 PM UTC, comment #1:

Patch

(file #19432)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 26 Oct 2013 08:47:32 PM UTC, original submission:

Max packet number in S2_5 is now 232. That's still plenty below 255, so I don't think having only 8bits for the packet type would cause problems. freeciv-web has some additional packets, but as it has incompatible network protocol completely reimplemented anyway, it's not a big problem here. So, should we revert the change that made packet type 16bit, of which upper byte is always 0, in S2_5?
That could possibly also resolve bug #20714 for S2_5.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19432:  8BitType-S2_5.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Dec 2013 05:42:14 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 07 Dec 2013 10:51:42 PM UTCcazfiAttached File-=>Added 8BitType-S2_5.patch, #19432
      StatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup