patchFreeciv - Patches: patch #4277, Build freeciv-ruledit as C++...

Show feedback again

patch #4277: Build freeciv-ruledit as C++ program

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun Oct 27 21:06:46 2013  
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sun Nov 3 23:58:42 2013, comment #1:

Existing build-dirs might have some problems on next build after I commit this. While the name of the source file changes, object file remains the same. Thus automatic dependency tracking thinks that dependency information about the object file is still valid, and will complain about missing ruledit.c. Maybe the least painful solution is to "touch ruledit.c && make && rm ruledit.c" to create temporary file to satisfy the dependency for the duration of the next build, which then updates dependency information for later builds.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Oct 27 21:06:46 2013, original submission:

As freeciv-ruledit is going to be Qt-program, module containing main() must be compiled as C++. Attached patch makes ruledit.c to be compiled as C++ file ruledit.cpp. Prior applying the patch one should make the file rename.
It would be cleaner to compile all modules of the freeciv-ruledit as C++, but making rulesave.c legal C++ code would require quite a lot of work and is not part of this patch.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #19266:  CPPRuledit.patch added by cazfi (4kB - text/x-diff)


   bug dependencies.

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Nov 4 00:00:11 2013cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
    Sun Oct 27 21:07:14 2013cazfiDependencies-=>Depends on bugs #21232
    Sun Oct 27 21:06:46 2013cazfiAttached File-=>Added CPPRuledit.patch, #19266
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup