patchFreeciv - Patches: patch #4279, Remove...

 
 
Show feedback again

patch #4279: Remove terrain_alteration_name_translation()

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 28 Oct 2013 01:02:18 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Nov 2013 10:39:25 PM UTC, SVN revision 23736:

Removed terrain_alteration_name_translation() that mapped between
alteration and specific extras (specials). Use real alteration name instead.

See patch #4279

(Browse SVN revision 23736)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 07 Nov 2013 01:28:11 AM UTC, comment #3:

Get rid of S_IRRIGATION & co references by removing terrain_alteration_name_translation() that mapped between alteration and specific extras (specials). Use real alteration name instead.

(file #19331)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 29 Oct 2013 01:35:11 PM UTC, comment #2:

> Once we fix is_native_tile_to_extra() to handle extras that are
> specials like it does for bases and roads, things may change a
> bit


Going forward this model has problem of requiring cardinally adjacent irrigation to city center for it to get irrigation bonus, while currently that's not the case.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Oct 2013 05:39:39 PM UTC, comment #1:

Rulesets currently work as they are. Once we fix is_native_tile_to_extra() to handle extras that are specials like it does for bases and roads, things may change a bit (for example currently "Farmland" alteration would be considered possible even if tile has no existign "Irrigation")

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Oct 2013 01:02:18 PM UTC, original submission:

Change TerrainAlter requirement to check possibility of adding any kind of extra to the tile instead of just one of the hardcoded ones.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19331:  TerrAltNameTransRm.patch added by cazfi (4kB - text/x-diff)
file #19268:  TerrAltExtra.patch added by cazfi (8kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Nov 2013 10:39:35 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 07 Nov 2013 01:28:11 AM UTCcazfiAttached File-=>Added TerrAltNameTransRm.patch, #19331
      SummaryTerrainAlter requirement to have any extra as target=>Remove terrain_alteration_name_translation()
    Mon 28 Oct 2013 05:39:39 PM UTCcazfiStatusIn Progress=>Ready For Test
    Mon 28 Oct 2013 01:30:00 PM UTCcazfiStatusReady For Test=>In Progress
    Mon 28 Oct 2013 01:02:18 PM UTCcazfiAttached File-=>Added TerrAltExtra.patch, #19268
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup