patchFreeciv - Patches: patch #4289, Make sure AI does not consider...

 
 
Show feedback again

patch #4289: Make sure AI does not consider effect with amount == 0 (no effect) positive thing

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 30 Oct 2013 10:38:44 AM UTC  
 
Category: aiPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 10 Nov 2013 11:02:21 PM UTC, SVN revision 23714:

Shortcut AI's effect value evaluation to return 0 if amount of the effect is 0.

See patch #4289

(Browse SVN revision 23714)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 10 Nov 2013 11:02:16 PM UTC, SVN revision 23713:

Shortcut AI's effect value evaluation to return 0 if amount of the effect is 0.

See patch #4289

(Browse SVN revision 23713)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 10 Nov 2013 11:02:11 PM UTC, SVN revision 23712:

Shortcut AI's effect value evaluation to return 0 if amount of the effect is 0.

See patch #4289

(Browse SVN revision 23712)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 30 Oct 2013 10:38:44 AM UTC, original submission:

Shortcut effect value evaluation to return 0 if amount of the effect is 0.
Old code often does not check if amount > 0, but just assumes so. If any ruleset has such effects (probably just as means to temporarily disable them for testing), it would assign them positive value (equal to having amount == 1).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19293:  0AmountEft.patch added by cazfi (858B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 10 Nov 2013 11:02:33 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 30 Oct 2013 10:38:44 AM UTCcazfiAttached File-=>Added 0AmountEft.patch, #19293
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup