patchFreeciv - Patches: patch #4297, Replace get_basic_special_sprite()...

 
 
Show feedback again

patch #4297: Replace get_basic_special_sprite() with fill_basic_extra_sprite_array()

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 07 Nov 2013 11:53:40 PM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 20 Nov 2013 11:50:27 PM UTC, SVN revision 23761:

Replaced get_basic_special_sprite() that assumed that any non-road, non-base extra would have
just one sprite, hardcoded by the type with new fill_basic_extra_sprite_array() that builds sprite
array for any extra based on extrastyle.

See patch #4297

(Browse SVN revision 23761)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 07 Nov 2013 11:53:40 PM UTC, original submission:

Replace get_basic_special_sprite() that assumed that any non-road, non-base extra would have just one sprite, hardcoded by the type. Introduce fill_basic_extra_sprite_array() that builds sprite array for any extra based on extrastyle.

gtk2- and gtk3-client editor code gets some duplicate code removed - functions building pixbuf for road was identical to one building pixbuf for base except for taking base_type instead of road_type. Now there's just one function taking extra_type.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19334:  FillExtraSpriteArray.patch added by cazfi (15kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 Nov 2013 11:50:37 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 07 Nov 2013 11:53:40 PM UTCcazfiAttached File-=>Added FillExtraSpriteArray.patch, #19334
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup