patchFreeciv - Patches: patch #4299, Minor bugs in nation ruleset...

 
 
Show feedback again

patch #4299: Minor bugs in nation ruleset loading error checking

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 09 Nov 2013 11:13:12 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.1,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 11 Nov 2013 08:49:42 PM UTC, SVN revision 23731:

Abort ruleset loading if too many nation groups defined in ruleset.

See gna patch #4299.

(Browse SVN revision 23731)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 08:44:10 PM UTC, SVN revision 23726:

Fix some minor bugs in nation ruleset loading error checking.

See gna patch #4299.

(Browse SVN revision 23726)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 08:38:02 PM UTC, SVN revision 23721:

Fix some minor bugs in nation ruleset loading error checking.

See gna patch #4299.

(Browse SVN revision 23721)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 09 Nov 2013 11:13:12 PM UTC, original submission:
  • Can double-free a seclist on errors (2.5 and later)
  • Trouble if too many nation groups are defined
  • Bail out earlier if there's a problem with leader titles (2.5 and later)
Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19342:  trunk-S2_5-ruleset-nation-load-error-checking.patch added by jtn (3kB - text/x-diff - trunk/S2_5/S2_4 r23711)
file #19343:  S2_4-ruleset-nation-load-error-checking.patch added by jtn (1kB - text/x-diff - trunk/S2_5/S2_4 r23711)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 11 Nov 2013 08:51:16 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sat 09 Nov 2013 11:57:28 PM UTCjtnDependencies-=>patch #4300 is dependent
    Sat 09 Nov 2013 11:54:38 PM UTCjtnAttached File-=>Added trunk-S2_5-ruleset-nation-load-error-checking.patch, #19342
      Attached File-=>Added S2_4-ruleset-nation-load-error-checking.patch, #19343
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup