patchFreeciv - Patches: patch #4300, Fix error with rulesets with no...

 
 
Show feedback again

patch #4300: Fix error with rulesets with no nation groups defined

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 09 Nov 2013 11:13:55 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.1,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 11 Nov 2013 08:49:54 PM UTC, SVN revision 23732:

Do not emit assertion failures for rulesets with no nation groups defined.

See gna patch #4300.

(Browse SVN revision 23732)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 08:44:17 PM UTC, SVN revision 23727:

Do not emit assertion failures for rulesets with no nation groups defined.

See gna patch #4300.

(Browse SVN revision 23727)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 08:38:10 PM UTC, SVN revision 23722:

Do not emit assertion failures for rulesets with no nation groups defined.

See gna patch #4300.

(Browse SVN revision 23722)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 09 Nov 2013 11:13:55 PM UTC, original submission:

Using a ruleset with no nation groups causes various assertion failures at ruleset load time.

Since the game has no hard requirement for there to be any nation groups (I think everything works OK without), this patch suppresses the errors during ruleset loading.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19344:  trunk-S2_5-allow-no-nation-groups.patch added by jtn (2kB - text/x-diff - trunk/S2_5/S2_4 r23711)
file #19345:  S2_4-allow-no-nation-groups.patch added by jtn (2kB - text/x-diff - trunk/S2_5/S2_4 r23711)

 

Digest:
   patch dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 11 Nov 2013 08:51:26 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sat 09 Nov 2013 11:57:28 PM UTCjtnDependencies-=>Depends on patch #4299
    Sat 09 Nov 2013 11:55:07 PM UTCjtnAttached File-=>Added trunk-S2_5-allow-no-nation-groups.patch, #19344
      Attached File-=>Added S2_4-allow-no-nation-groups.patch, #19345
      StatusIn Progress=>Ready For Test
    Sat 09 Nov 2013 11:22:29 PM UTCjtnDependencies-=>patch #4303 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup