patchFreeciv - Patches: patch #4304, Rename 'is_available' property of...

 
 
Show feedback again

patch #4304: Rename 'is_available' property of nations to 'is_pickable', and make it client-only

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 09 Nov 2013 11:39:24 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 22 Dec 2013 02:48:37 PM UTC, SVN revision 23883:

Rename 'is_available' property of nations to 'is_pickable' to better
reflect its purpose, and make it a network/client specific notion -- on
the server we now track individual reasons why a nation can't be picked
(currently only lack of a start position). No functional change.

See gna patch #4304.

(Browse SVN revision 23883)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 22 Dec 2013 02:45:19 PM UTC, SVN revision 23878:

Rename 'is_available' property of nations to 'is_pickable' to better
reflect its purpose, and make it a network/client specific notion -- on
the server we now track individual reasons why a nation can't be picked
(currently only lack of a start position). No functional change.

See gna patch #4304.

(Browse SVN revision 23878)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 20 Dec 2013 10:38:05 PM UTC, comment #2:

Second go, at last. As well as the renaming, this version makes the "is_pickable" variable a client/network property; on the server, finer-grained information is kept (such as "no_startpos" for tracking whether a nation has a start position in the current scenario). Still no functional change.

(file #19501)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 11 Nov 2013 08:37:00 PM UTC, comment #1:

Having some second thoughts about this, despite it having sat unchanged in my patch stack for months; mostly precipitated by bug #21268. I won't commit this just yet; it may change shape quite a bit before I resubmit.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 09 Nov 2013 11:39:24 PM UTC, original submission:

While working on patch #3448, I found the member name 'is_available' a misleading name for what it does. I've chosen 'is_pickable' as being possibly a bit better ("Whether the client is allowed to try to pick the nation at game start").

Also, many comment updates regarding its use and related topics, particularly its interaction with nation map start positions.

No functional change in this patch (except to some log_verbose() messages).

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19501:  trunk-S2_5-is_pickable-bis.patch added by jtn (19kB - text/x-patch - trunk/S2_5 r23872)
file #19349:  trunk-S2_5-is_pickable.patch added by jtn (20kB - text/x-diff - trunk/S2_5/S2_4 r23711)

 

Depends on the following items: None found

Digest:
   bug dependencies, patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Dec 2013 02:50:18 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 20 Dec 2013 11:35:41 PM UTCjtnDependencies-=>patch #4348 is dependent
    Fri 20 Dec 2013 11:35:10 PM UTCjtnDependencies-=>patch #4347 is dependent
    Fri 20 Dec 2013 10:38:05 PM UTCjtnAttached File-=>Added trunk-S2_5-is_pickable-bis.patch, #19501
      StatusIn Progress=>Ready For Test
      SummaryRename \'is_available\' property of nations to \'is_pickable\'=>Rename 'is_available' property of nations to 'is_pickable', and make it client-only
    Sun 15 Dec 2013 11:31:59 AM UTCjtnDependencies-=>patch #3448 is dependent
    Mon 11 Nov 2013 08:37:00 PM UTCjtnStatusReady For Test=>In Progress
    Sat 09 Nov 2013 11:56:22 PM UTCjtnAttached File-=>Added trunk-S2_5-is_pickable.patch, #19349
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup