patchFreeciv - Patches: patch #4347, Refactor Gtk clients' nation...

 
 
Show feedback again

patch #4347: Refactor Gtk clients' nation selection dialog

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 20 Dec 2013 10:41:53 PM UTC  
 
Category: client-gtk-2.0Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 22 Dec 2013 02:48:50 PM UTC, SVN revision 23885:

Refactor Gtk clients' nation selection dialog, with the following aims:
- Prepare for the set of pickable nations to change while it's up
- (and hence, the set of nation group tabs in the notebook; this
avoids empty tabs in scenarios restricted to a subset of nations)
- Restore the player's current nation settings, leader name etc when
the dialog is popped up
- Highlight the selected nation correctly when changing group tabs

See gna patch #4347.

(Browse SVN revision 23885)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 22 Dec 2013 02:45:35 PM UTC, SVN revision 23880:

Refactor Gtk clients' nation selection dialog, with the following aims:
- Prepare for the set of pickable nations to change while it's up
- (and hence, the set of nation group tabs in the notebook; this
avoids empty tabs in scenarios restricted to a subset of nations)
- Restore the player's current nation settings, leader name etc when
the dialog is popped up
- Highlight the selected nation correctly when changing group tabs

See gna patch #4347.

(Browse SVN revision 23880)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 20 Dec 2013 10:41:53 PM UTC, original submission:

Mainly in preparation for patch #3448, but also with some immediate benefits.

  • Prepare for the set of pickable nations to change while this dialog is up
    • (and hence, the set of nation group tabs in the notebook; this avoids empty tabs in scenarios restricted to a subset of nations)
  • Restore the player's current nation settings, leader name etc when the dialog is popped up
  • Highlight the selected nation correctly when changing group tabs

Patch changes both Gtk2 and Gtk3 clients.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19503:  trunk-S2_5-gtk-races-refactor.patch added by jtn (59kB - text/x-patch - trunk/S2_5 r23872 + patch #4304)

 

Digest:
   patch dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Dec 2013 02:50:58 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 20 Dec 2013 11:36:24 PM UTCjtnDependencies-=>patch #4349 is dependent
    Fri 20 Dec 2013 11:35:10 PM UTCjtnDependencies-=>Depends on patch #4304
    Fri 20 Dec 2013 10:41:53 PM UTCjtnAttached File-=>Added trunk-S2_5-gtk-races-refactor.patch, #19503
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup