patchFreeciv - Patches: patch #4348, Server/network changes for...

 
 
Show feedback again

patch #4348: Server/network changes for nationsets

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 20 Dec 2013 11:24:45 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 22 Dec 2013 02:49:05 PM UTC, SVN revision 23886:

Replace the old 'soft' notion of 'nation sets' with a new, stronger
notion, controlled by a new server setting 'nationset'.
Nations outside the current set can no longer appear in the game in any
circumstances, and the number of players is limited by the number of
available nations. In standard rulesets, the 'nationset' setting must
now be changed to access any nations outside the "core" set.
Clients only minimally updated: if the nationset is changed, any nation
dialog that is up at the time will be popped down.

See gna patch #4348.

(Browse SVN revision 23886)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 22 Dec 2013 02:45:46 PM UTC, SVN revision 23881:

Replace the old 'soft' notion of 'nation sets' with a new, stronger
notion, controlled by a new server setting 'nationset'.
Nations outside the current set can no longer appear in the game in any
circumstances, and the number of players is limited by the number of
available nations. In standard rulesets, the 'nationset' setting must
now be changed to access any nations outside the "core" set.
Clients only minimally updated: if the nationset is changed, any nation
dialog that is up at the time will be popped down.

See gna patch #4348.

(Browse SVN revision 23881)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 20 Dec 2013 11:24:45 PM UTC, original submission:

This patch implements the core of the nation sets design of patch #3448:

  • Adds a new server setting "nationset"
  • Adds a notion of nation sets separate from groups, with all the support functions and network changes
  • Allows nations' is_pickable to change during the pregame by moving it to a separate network packet
  • Limits nations to those in the current set

It only adds minimal changes to clients to make them "safe" (by popping down any nation picker when the nation set changes). Full client support will be in other tickets.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19504:  trunk-nationsets.patch added by jtn (83kB - text/x-patch - trunk/S2_5 r23872 + patch #4304)
file #19505:  S2_5-nationsets.patch added by jtn (82kB - text/x-patch - trunk/S2_5 r23872 + patch #4304)

 

Digest:
   patch dependencies.

Digest:
   task dependencies, patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Dec 2013 02:51:12 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 20 Dec 2013 11:37:33 PM UTCjtnDependencies-=>patch #3448 is dependent
    Fri 20 Dec 2013 11:36:42 PM UTCjtnDependencies-=>patch #4349 is dependent
    Fri 20 Dec 2013 11:35:41 PM UTCjtnDependencies-=>Depends on patch #4304
    Fri 20 Dec 2013 11:29:41 PM UTCjtnAttached File-=>Added trunk-nationsets.patch, #19504
      Attached File-=>Added S2_5-nationsets.patch, #19505
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup