patchFreeciv - Patches: patch #4354, Restrict help to nations in...

 
 
Show feedback again

patch #4354: Restrict help to nations in current nationset

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 24 Dec 2013 11:04:39 PM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 26 Dec 2013 01:42:00 PM UTC, SVN revision 23904:

Restrict online help to nations in current nationset once the game has
started.

See gna patch #4354.

(Browse SVN revision 23904)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 26 Dec 2013 01:41:14 PM UTC, SVN revision 23902:

Restrict online help to nations in current nationset once the game has
started.

See gna patch #4354.

(Browse SVN revision 23902)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 25 Dec 2013 01:38:19 AM UTC, comment #1:

> can't easily check right now that freeciv-ruledit still compiles


It does.

Marko Lindqvist <cazfi>
Project Administrator
Tue 24 Dec 2013 11:04:39 PM UTC, original submission:

Per patch #3448 comment 3, this patch restricts the built-in help on nations to those in the current set, so that untranslated text doesn't show up by default.

The restriction kicks in once the game has started. This is a bit of a bodge, but I didn't want to "reboot" the help texts every time the nationset changed in pregame. (The help system could do with reworking a bit.)

(I've fixed up freeciv-manual, but can't easily check right now that freeciv-ruledit still compiles -- but I don't see why it shouldn't.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19514:  trunk-S2_5-nationsets-help.patch added by jtn (2kB - text/x-diff - trunk/S2_5 r23894)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 26 Dec 2013 01:42:37 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Tue 24 Dec 2013 11:16:52 PM UTCjtnAttached File-=>Added trunk-S2_5-nationsets-help.patch, #19514
      StatusIn Progress=>Ready For Test
    Tue 24 Dec 2013 11:05:10 PM UTCjtnDependencies-=>patch #3448 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup