patchFreeciv - Patches: patch #4396, Check validity of 'survives'...

 
 
Show feedback again

patch #4396: Check validity of 'survives' requirement field

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 03 Jan 2014 04:06:43 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.2,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 05 Jan 2014 10:59:09 AM UTC, SVN revision 24047:

Check whether requirement 'survives' field is valid at ruleset load time.

See gna patch #4396.

(Browse SVN revision 24047)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 05 Jan 2014 10:54:51 AM UTC, SVN revision 24035:

Check whether requirement 'survives' field is valid at ruleset load time.

See gna patch #4396.

(Browse SVN revision 24035)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 05 Jan 2014 10:47:17 AM UTC, SVN revision 24022:

Check whether requirement 'survives' field is valid at ruleset load time.

See gna patch #4396.

(Browse SVN revision 24022)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 03 Jan 2014 04:06:43 AM UTC, original submission:

Currently, there's no check at ruleset load time that the 'survives' field of a requirement is valid. Very few requirements support this, so it would probably be helpful to have a check for ruleset authors.

(Bug #21418 comment 1 points out that such checking would be useful in sanity_check_ruleset_data() for freeciv-ruledit, but my current patch puts it in req_from_str(). However, my fix for that bug puts infrastructure in place to allow us to easily move this logic later.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19642:  S2_5-check-surviving-reqs.patch added by jtn (3kB - text/x-diff - trunk/S2_5/S2_4 r24003)
file #19643:  S2_4-check-surviving-reqs.patch added by jtn (3kB - text/x-diff - trunk/S2_5/S2_4 r24003)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 05 Jan 2014 11:03:49 AM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 03 Jan 2014 08:06:51 PM UTCjtnAttached File-=>Added S2_5-check-surviving-reqs.patch, #19642
      Attached File-=>Added S2_4-check-surviving-reqs.patch, #19643
      StatusIn Progress=>Ready For Test
      Planned Release=>2.4.2,2.5.0,2.6.0
    Fri 03 Jan 2014 05:18:05 AM UTCjtnDependencies-=>Depends on bugs #21422
    Fri 03 Jan 2014 05:17:57 AM UTCjtnAttached File-=>Added trunk-check-surviving-reqs.patch, #19626
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup