patchFreeciv - Patches: patch #4408, Check for AutoOnCityCenter extras...

Show feedback again

patch #4408: Check for AutoOnCityCenter extras in more circumstances (not just gaining tech)

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat Jan 4 19:59:34 2014  
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Mon Apr 14 02:22:21 2014, comment #3:

Note that technologies are special here, in that unlike most of the other sensible requirements (improvements(including non-wonders: perhaps a city needs a "Train Station" to have "Railroad" or similar), terrain alternations, government, etc.), it is possible for a player to gain a tech mid-turn (using UTYF_TRADE_ROUTE units, either founding a trade route or entering a market).

Emmet Hikory <persia>
Project Member
Sun Jan 5 03:28:27 2014, comment #2:

As with city range requirements, I would go to "check once a turn" model with this.

1) Any kind of requirement gets checked, and at well-defined point (unlike enabler itself not being checked, but getting noticed next time something completely unrelated happens to tricker the check)
2) Never multiple heavy nested iterations (all cities * all road types * all reqs) in turn change when multiple things change at once (gaining tech, multiple wonders getting finished, global warming caused terrain changes everywhere...)

Requirements that can change mid-turn are rare, and we probably wouldn't be testing any of those anyway?

Marko Lindqvist <cazfi>
Project Administrator
Sat Jan 4 20:00:58 2014, comment #1:

...maybe Government too?

Jacob Nevins <jtn>
Project Administrator
Sat Jan 4 19:59:34 2014, original submission:

Currently we only call upgrade_all_city_extras() when a player discovers a new tech, and only for that player's cities, even though technically any requirement could trigger a transition.
In other tickets, discussion has highlighted that we might want to do so in other places:

  • In patch #4405, I suggested that buildings (wonders) could trigger free city extras. (Should this only check the current player, or all players?)
  • In bug #21403, I wondered if city tile terrain change should trigger a check, in case it causes a requirement for an AutoOnCityCenter extra to be fulfilled.

However, need to figure out the semantics of AutoOnCityCenter; see discussion in bug #21403.

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup