patchFreeciv - Patches: patch #4447, UI for seeing/changing player...

 
 
Show feedback again

patch #4447: UI for seeing/changing player colours in pregame

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Wed 22 Jan 2014 11:41:19 PM UTC  
 
Category: clientPriority: 3 - Low
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 26 Jan 2014 12:29:03 PM UTC, comment #1:

For best usability it probably also wants a network bit for "you can/can't try to change colour" (set by the server based on plrcolormode), to avoid the user carefully choosing a colour and only then being told it won't work.
Currently this is the same for every player (modulo permissions) but for future expandability the bit should probably be per-player.

Jacob Nevins <jtn>
Project Administrator
Wed 22 Jan 2014 11:41:19 PM UTC, original submission:

Now that we have all the machinery for choosing player colours, it would be nice if there were client UI for it.

In the Gtk client, I'm thinking of a little box of colour like in the in-game Nations (F3) report, and an option (maybe on the right-click menu) to bring up a colour chooser.

One thing that's missing is a way for the server to signal to the client that a player has no assigned colour yet -- there should be a boolean flag for this. (If fixing on stable branches, it'd need an optional capability, and with old servers the client would display black, which would be adequate.

When I was cleaning up the player colour code for 2.4.0 I wrote a test patch which coloured some text in the pregame list, to show that the client gets prompt updates when the colour scheme changes etc. Attached from my stash for completeness, but it probably no longer applies.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19824:  gtk-pregame-colours.patch added by jtn (3kB - text/x-diff - hack patch to show player colours in pregame, circa Aug 2012 (against trunk?))

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 22 Jan 2014 11:41:19 PM UTCjtnAttached File-=>Added gtk-pregame-colours.patch, #19824
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup