patchFreeciv - Patches: patch #4459, Requirement range...

Show feedback again

patch #4459: Requirement range "Traderoutes"

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri Jan 31 02:13:45 2014  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Emmet Hikory <persia>Open/Closed: Closed
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Jul 12 21:38:01 2014, SVN revision 25512:


Requested by Marko Lindqvist

See patch #4459

(Browse SVN revision 25512)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri Jul 11 07:04:22 2014, comment #3:

Patch attached that just mirrors the requirements calculations for cities. Whether it happens to be correct or not depends on the data state of the caller, so the client may get the wrong answers if it has incomplete (or out of date) knowledge. Should be minimally usable, so that if refinements are necessary to the specific range tests, these can be done separately from the range definition.

(file #21352)

Emmet Hikory <persia>
Project MemberIn charge of this item.
Mon Jul 7 23:43:22 2014, comment #2:

Like with any requirements, server should use correct information. It's largely ruleset author's responsibility to design ruleset so that client's imperfect knowledge does not cause bad usability - giving happiness penalty based on trade partners internals would be a bad idea as then client would show that city will remain happy when it in fact is about to go in disorder.

Marko Lindqvist <cazfi>
Project Administrator
Sun Apr 27 09:28:59 2014, comment #1:

I thought I'd try this, but ran into some uncertainties for some requirement types.

For Extra, BaseFlag, RoadFlag, Terrain, Resource, TerrainCass, TerrainFlag, and MinSize should whether the current player knows and/or sees the qualifying thing in the trade partner city be checked (possibly returning TRI_MAYBE), or should the requirement be applied against the current state of affairs independently of the player's knowledge?

For Building, should this be restricted to one's own cities + visible buildings (the set of known buildings)? Should there be some tracking of buildings believed to be present as a result of city investigations: if so, would these qualify to meet the requirement if present?

For Nationality and MinCulture, should these only apply to one's own cities, or perhaps use some investigation tracking similar to that mentioned in the Buildings question?

Emmet Hikory <persia>
Project MemberIn charge of this item.
Fri Jan 31 02:13:45 2014, original submission:

No actual patch yet, to avoid conflicts with patch #4388 development.

Add requirement range "Traderoute" that checks the city & the cities it has traderoute with.
This can be used for things like traderoute-transmitted wonder effects, or for some strategic resource models.

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #21352:  add-REQ_RANGE_TRADEROUTE.patch added by persia (37kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Jul 12 21:40:08 2014persiaStatusReady For Test=>Done
    Fri Jul 11 07:04:22 2014persiaAttached File-=>Added add-REQ_RANGE_TRADEROUTE.patch, #21352
      StatusNeed Info=>Ready For Test
    Tue Jun 17 22:31:13 2014persiaStatusNone=>Need Info
      Assigned toNone=>persia
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup