patchFreeciv - Patches: patch #4515, Option to leave phase open from...

 
 
Show feedback again

patch #4515: Option to leave phase open from adv_data_get() and dai_plr_data_get()

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 18 Feb 2014 01:27:14 AM UTC  
 
Category: aiPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.3, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 22 Feb 2014 03:29:25 AM UTC, comment #4:

One of the problems fixed by this was bug #21616.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 22 Feb 2014 03:26:06 AM UTC, SVN revision 24533:

Added bool pointer parameter 'close' for adv_data_get() and dai_plr_data_get().
If it's not NULL, caller promises to close the phase after the call if needed.
We can then leave the phase open when necessary and via that pointer set the information
for the caller if it should close the phase or not.

See patch #4515

(Browse SVN revision 24533)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 22 Feb 2014 03:26:00 AM UTC, SVN revision 24532:

Added bool pointer parameter 'close' for adv_data_get() and dai_plr_data_get().
If it's not NULL, caller promises to close the phase after the call if needed.
We can then leave the phase open when necessary and via that pointer set the information
for the caller if it should close the phase or not.

See patch #4515

(Browse SVN revision 24532)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 22 Feb 2014 03:25:53 AM UTC, SVN revision 24531:

Added bool pointer parameter 'close' for adv_data_get() and dai_plr_data_get().
If it's not NULL, caller promises to close the phase after the call if needed.
We can then leave the phase open when necessary and via that pointer set the information
for the caller if it should close the phase or not.

See patch #4515

(Browse SVN revision 24531)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 18 Feb 2014 01:27:14 AM UTC, original submission:

If called outside players phase, adv_data_get() and dai_plr_data_get() return pointer to incomplete data (it doesn't matter if it recalculates some of the data or not) as closing the phase has freed some parts.

This patchs adds bool pointer parameter to these functions. If it's not NULL, caller promises to close the phase after the call if needed. We can then leave the phase open and via that pointer set the information for the caller if it should close the phase or not.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20095:  DataClose.patch.bz2 added by cazfi (5kB - application/x-bzip)
file #20096:  DataClose-S2_5.patch.bz2 added by cazfi (5kB - application/x-bzip)
file #20097:  DataClose-S2_4.patch added by cazfi (23kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Feb 2014 03:26:51 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 18 Feb 2014 01:27:14 AM UTCcazfiAttached File-=>Added DataClose.patch.bz2, #20095
      Attached File-=>Added DataClose-S2_5.patch.bz2, #20096
      Attached File-=>Added DataClose-S2_4.patch, #20097
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup