patchFreeciv - Patches: patch #4520, Hard rule to prevent extra...

 
 
Show feedback again

patch #4520: Hard rule to prevent extra unambigiuous with terrain change

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 19 Feb 2014 04:56:31 AM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 01 Mar 2014 07:33:47 AM UTC, SVN revision 24589:

Made next_extra_for_tile() to return NULL if EC_IRRIGATION extra is searched for a
tile that would be transformed by irrigate activity. Similar for EC_MINE and mining
activity.

See patch #4520

(Browse SVN revision 24589)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 25 Feb 2014 06:19:17 AM UTC, comment #2:

Make targeted fix to next_extra_for_tile() where the activity being planned is known instead.

(file #20182)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 25 Feb 2014 05:26:50 AM UTC, comment #1:

Problem: This checks extra cause to determine if we're trying to build irrigation extra instead of irrigation terrain transformation, or to build mining extra instead mining terrain transformation. Result is not guaranteed to tell the activity currently planned, as extra can have multiple causes. We may return FALSE for some other activity simply because it would be impossible to irrigate the extra into existence.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 19 Feb 2014 04:56:31 AM UTC, original submission:

Introduce it to the very lowest level of checking if extra can be built to an tile that EC_IRRIGATION extra cannot be added to an tile that will get transformed by Irrigation activity, nor EC_MINE extra to an tile that will transformed by Mining activity.

This probably fixes other problems in AI and Advisor code, but the real effect is seen in startpos generation - Forest with Irrigation is no longer seen as the best possible startpos.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 01 Mar 2014 07:33:55 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 25 Feb 2014 06:19:17 AM UTCcazfiAttached File-=>Added NextIrrigationMineTransformTile.patch, #20182
      StatusIn Progress=>Ready For Test
    Tue 25 Feb 2014 05:26:50 AM UTCcazfiStatusReady For Test=>In Progress
    Wed 19 Feb 2014 04:56:31 AM UTCcazfiAttached File-=>Added NextExtraNotTransform.patch, #20113
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup