patchFreeciv - Patches: patch #4582, Story telling: Move the action UI...

Show feedback again

patch #4582: Story telling: Move the action UI names to the rule set

Submitted by:  Sveinung Kvilhaugsvik <sveinung>
Submitted on:  Tue 04 Mar 2014 08:59:48 PM UTC  
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Fri 26 Dec 2014 12:31:04 AM UTC, SVN revision 27410:

Let ruleset authors specify the action name shown to the user in the UI.

This can be used to give the actions names that fits the story of the
ruleset. This allows ruleset authors to avoid having the game breaking the
suspension of disbelief by offering to poison a city populated by inorganic

It can also be used to set what mnemonic an action should have in the action
selection dialog. Bug #23088 changed the default mnemonic for some actions
to avoid collisions. Giving two actions the same mnemonic isn't a problem in
a ruleset were they never will share an action selection dialog.

The ruleset variables are conservatively named to avoid giving the
impression that generalized actions are supported in 2.6.

See patch #4582

(Browse SVN revision 27410)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Mon 22 Dec 2014 11:19:49 PM UTC, comment #2:

WIP patch.

Conservative implementation. (Hopefully conservative enough to go into 2.6) In stead of introducing syntax that gives the impression that actions now are generalized each action ui name variable has a name of its own.

(file #23271)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed 17 Dec 2014 12:12:39 PM UTC, comment #1:

Another advantage of making the UI names ruleset configurable is that actions that never will appear in the same action selection dialog can use the same mnemonic. (See bug #23088)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue 04 Mar 2014 08:59:48 PM UTC, original submission:

Some rule sets try to tell a story. One example is the alien rule set that starts with a story telling pop up and has story telling in its tech descriptions. In bug #21710 adding quotes to techs was suggested.

When telling a story the suspension of disbelief[1] is important. If elements of the story contradicts it self, like if a nation of AI computers powered by nuclear fusion being killed by having their water supply poisoned without any plausible explanation why it would kill them, the audience is reminded that what happens in the story isn't real. This makes the story worse than it could be.

By allowing rule set authors to decide the name the UI displays when the player choose an action the above case can be avoided. Naming the action that kill some citizens "Kill citizens" in stead of "Poison city" would work in a rule set with some nuclear powered AI civilizations and some human civilizations. In other settings naming it "Terrorist attack" would work better.


Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #23280:  RulesetActionNames.patch added by sveinung (26kB - text/x-patch)
file #23271:  RulesetActionNames.patch added by sveinung (26kB - text/x-patch)


   patch dependencies.

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by sveinung (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 26 Dec 2014 12:31:29 AM UTCsveinungStatusReady For Test=>Done
    Tue 23 Dec 2014 04:05:06 PM UTCsveinungStatusIn Progress=>Ready For Test
    Tue 23 Dec 2014 04:05:05 PM UTCsveinungAttached File-=>Added RulesetActionNames.patch, #23280
    Mon 22 Dec 2014 11:19:49 PM UTCsveinungAttached File-=>Added RulesetActionNames.patch, #23271
    Wed 05 Mar 2014 08:32:25 AM UTCsveinungDependencies-=>Depends on patch #4585
    Tue 04 Mar 2014 09:00:34 PM UTCsveinungDependencies-=>Depends on patch #4581
      Dependencies-=>Depends on patch #4580
      Dependencies-=>Depends on patch #4579
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup