patchFreeciv - Patches: patch #4589, City styles to depend on Styles

 
 
Show feedback again

patch #4589: City styles to depend on Styles

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 08 Mar 2014 02:30:26 AM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 20 Mar 2014 05:45:31 AM UTC, SVN revision 24700:

Made initial city styles to be derived from national styles. User selects national
style, not city style.

See patch #4589

(Browse SVN revision 24700)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 16 Mar 2014 02:37:51 AM UTC, comment #2:

- Fixed handling of cases where the style defined in nation ruleset is not defined in styles.ruleset

(file #20351)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 14 Mar 2014 03:13:14 AM UTC, comment #1:

- Fixed gtk3-client bug that all city styles were listed, and multiple times, as initial styles
- Introduced basic_city_style_for_style() function and use it where appropriate
- Added ruleset loading time sanity checking that all nation styles have basic city style for them.
- Consider last matching city style as the representative city style for nation style, optimize for that.

(file #20322)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 08 Mar 2014 02:30:26 AM UTC, original submission:

Make initial city styles to require certain national styles. User selects nation style, not city style.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20351:  CityStyles-3.patch.bz2 added by cazfi (12kB - application/x-bzip)
file #20322:  CityStyles-2.patch.bz2 added by cazfi (12kB - application/x-bzip)
file #20278:  CityStyles.patch.bz2 added by cazfi (12kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 20 Mar 2014 05:45:43 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 16 Mar 2014 02:37:51 AM UTCcazfiAttached File-=>Added CityStyles-3.patch.bz2, #20351
    Fri 14 Mar 2014 03:13:14 AM UTCcazfiAttached File-=>Added CityStyles-2.patch.bz2, #20322
    Sat 08 Mar 2014 02:30:26 AM UTCcazfiAttached File-=>Added CityStyles.patch.bz2, #20278
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup