patchBattle for Wesnoth - Patches: patch #4596, add a number box widget for...

Show feedback again

patch #4596: add a number box widget for numerical input

Submitted by:  Sebastia Kölle <aquileia>
Submitted on:  Mon Mar 10 15:17:37 2014  
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Fri Mar 14 23:41:22 2014, comment #8:

I made this patch a pull request on GitHub as all issues I know of are solved.

(file #20332, file #20333, file #20334)

Sebastia Kölle <aquileia>
Project Member
Fri Mar 14 15:51:05 2014, comment #7:

For paste_selection, I'd need some feedback from mordante... but everything else should work.

(file #20323, file #20324, file #20325)

Sebastia Kölle <aquileia>
Project Member
Thu Mar 13 00:05:37 2014, comment #6:

I fixed both num_box and the vim file locally, but I want to get Wesnoth compiled before uploading a patch (right now the link command needs zlib). I'll do that on Friday.

Please wait with reviewing for the update.

Sebastia Kölle <aquileia>
Project Member
Wed Mar 12 12:26:06 2014, comment #5:

There's an invalid ("gridrow") entry in the taglist. Also, if you mention the grep command in the syntax file, you might want to append an -o flag since that actually outputs a much better formatted list than what I gave you :)

Otherwise (the Vim part) looks good to me.

B. Lipka <lipk>
Project Member
Wed Mar 12 11:47:37 2014, comment #4:

Thanks for testing!

I merged the three tag lists (adding 4 entries to lipk's list) and added another patch for Vim.

I also added the indentation of some macros in lobby_main that lipk's grep pointed to. I can easily exclude these changes from the final patch if they are unwanted.

(file #20310)

Sebastia Kölle <aquileia>
Project Member
Wed Mar 12 09:04:10 2014, comment #3:

In the Vim patch, a space is missing from between listbox and multi_page. There's also a lot of tags missing (the absence of [row] and [column] is the most prominent since these are very often used).

I attached the output of 'grep "\[[a-z,_,-]*\]" *.cfg --no-filename | sort | uniq' in data/gui/widget and data/gui/window, hopefully listing all the tags that should be in the syntax file.

(file #20308, file #20309)

B. Lipka <lipk>
Project Member
Tue Mar 11 03:27:18 2014, comment #2:

Next time I'll grep all of Wesnoth, not only src...

I always wondered whether the integer_selector interface allows to automatically transmit the tag keys - now I know it doesn't and I just didn't find the code where it's actually done.

(file #20301)

Sebastia Kölle <aquileia>
Project Member
Tue Mar 11 02:32:32 2014, comment #1:

There is one thing that remains to be tested... if you delete the last digit so that the box reads "", will it default to 0 or ignore you? I couldn't figure out by looking at the code of lexical_cast, so testing seems the easiest way to verify it works.

Sebastia Kölle <aquileia>
Project Member
Mon Mar 10 15:17:37 2014, original submission:

The first of three widgets I hope to implement:
1. number box
2. spinner (number box with increment and decrement buttons)
3. vertical slider

The code isn't tested yet because I have no building environment.

Sebastia Kölle <aquileia>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #20332:  0005-new-GUI2-widget-num_box.patch added by aquileia (13kB - application/octet-stream)
file #20323:  0001-new-GUI2-widget-num_box.patch added by aquileia (21kB - application/octet-stream)
file #20308:  missing-tags-widget added by lipk (1kB - application/octet-stream)
file #20309:  missing-tags-window added by lipk (6kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by lipk (Updated the item)
  • -unavailable- added by aquileia (Submitted the item)
  • -unavailable- added by aquileia

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 17 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Mar 14 23:41:22 2014aquileiaAttached File-=>Added 0005-new-GUI2-widget-num_box.patch, #20332
      Attached File-=>Added 0006-register-num_box-for-compilation-syntax.patch, #20333
      Attached File-=>Added 0008-Switch-the-order-of-variables-in-num_box.hpp.patch, #20334
    Fri Mar 14 15:51:05 2014aquileiaAttached File-=>Added 0001-new-GUI2-widget-num_box.patch, #20323
      Attached File-=>Added 0002-add-GUI-tag-list-for-Vim-syntax-highlighting.patch, #20324
      Attached File-=>Added 0003-minor-fixes-in-the-wake-of-creating-number_box.patch, #20325
    Wed Mar 12 11:47:37 2014aquileiaAttached File-=>Added 0001-more-GUI-tags-for-Vim-syntax-highlighting.patch, #20310
    Wed Mar 12 09:04:10 2014lipkAttached File-=>Added missing-tags-widget, #20308
      Attached File-=>Added missing-tags-window, #20309
    Tue Mar 11 17:09:26 2014aquileiaAttached File-=>Added 0001-num-box-add-support-for-up-down-arrows.patch, #20303
    Tue Mar 11 17:09:01 2014aquileiaCarbon-CopyRemoved lipk=>-
    Tue Mar 11 15:00:25 2014aquileiaAttached File-=>Added 0001-fix-num_box-and-its-documentation.patch, #20302
    Tue Mar 11 03:27:18 2014aquileiaAttached File-=>Added 0001-num_box-connecting-tag-and-widget.patch, #20301
    Mon Mar 10 21:35:34 2014aquileiaAttached File-=>Added 0001-Update-syntax-highlighting-for-vim-and-emacs.patch, #20295
      Carbon-Copy-=>Added lipk
    Mon Mar 10 15:17:37 2014aquileiaAttached File-=>Added 0001-add-a-number-box-widget-for-numerical-input.patch, #20293
      Carbon-Copy-=>Added mordante
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup