patchFreeciv - Patches: patch #4620, Working implementation of...

 
 
Show feedback again

patch #4620: Working implementation of sdl2-client info labels

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 17 Mar 2014 10:41:39 PM UTC  
 
Category: client-sdl2Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 22 Mar 2014 10:50:51 PM UTC, SVN revision 24712:

Do not free info label surface while it's still going to be used. Fixes also
double free crash when it finally is time to free it.

See patch #4620

(Browse SVN revision 24712)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 17 Mar 2014 10:41:39 PM UTC, original submission:

- As sdl2-client uses info label surface created itself, and not
copy of it, do not FREESURFACE() it after assigning to use.
This fixes a crash when ever mouse is over a widget that would
emit tooltip.
- Use final variable from the beginning
- Renamed pInfo_Label as info_label

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20368:  InfoLabelDoubleFree.patch added by cazfi (7kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Mar 2014 10:51:01 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 17 Mar 2014 10:41:39 PM UTCcazfiAttached File-=>Added InfoLabelDoubleFree.patch, #20368
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup