patchFreeciv - Patches: patch #4629, Even with "Claim_Ocean"...

 
 
Show feedback again

patch #4629: Even with "Claim_Ocean" tech, land cities do not claim ocean

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 22 Mar 2014 07:37:11 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 15 Apr 2015 05:30:24 AM UTC, SVN revision 28788:

Added tech flag "Claim_Ocean_Limited"

See patch #4629

(Browse SVN revision 28788)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 15 Apr 2015 05:30:04 AM UTC, SVN revision 28787:

Added tech flag "Claim_Ocean_Limited"

See patch #4629

(Browse SVN revision 28787)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 09 Apr 2015 10:26:21 PM UTC, comment #2:

> Is it ok to just change the "Claim_Ocean" flag like this, or do
> we need to provide method for getting the old behavior


Attached version of the patch keeps the old "Claim_Ocean" behavior and just adds the new behavior as "Claim_Ocean_Limited"

(file #24213)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 19 Jul 2014 08:54:53 PM UTC, comment #1:

- Updated against svn

(file #21472)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 22 Mar 2014 07:37:11 PM UTC, original submission:

In practice, "Claim_Ocean" tech flag granting techs are far too powerful. The purpose of the flag was to make it possible to give oceanic cities tiles to work on more than the central 9. In practice the tech blocks most of the movement of peaceful ships anywhere near the land cities even if player never builds any oceanic cities.

Attached patch makes only Oceanic border sources to be able to claim oceanic tiles even when tech with "Claim_Ocean" flag is known.

Is it ok to just change the "Claim_Ocean" flag like this, or do we need to provide method for getting the old behavior, in case some ruleset has been built to depend on it on 2.5?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24213:  ReworkedClaimOceanTech-3.patch added by cazfi (8kB - text/plain-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Apr 2015 05:30:37 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 09 Apr 2015 10:26:21 PM UTCcazfiAttached File-=>Added ReworkedClaimOceanTech-3.patch, #24213
      Planned Release2.6.0=>2.6.0, 3.0.0
    Sat 19 Jul 2014 08:54:53 PM UTCcazfiAttached File-=>Added ReworkedClaimOceanTech-2.patch, #21472
    Sat 22 Mar 2014 07:37:11 PM UTCcazfiAttached File-=>Added ReworkedClaimOceanTech.patch, #20405
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup