patchFreeciv - Patches: patch #4764, Adjusting local settings from main...

 
 
Show feedback again

patch #4764: Adjusting local settings from main menu

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 01 Jun 2014 08:11:48 PM UTC  
 
Category: client-gtk-3.0Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 10 Nov 2014 10:44:16 PM UTC, SVN revision 27025:

Made client settings accessible from gtk-client main view,
notably allowing changing tileset to a compatible one from
gui before connecting to server.

See patch #4764

(Browse SVN revision 27025)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 07 Nov 2014 11:46:37 PM UTC, comment #2:

- Updated against svn HEAD, which no longer has no ggz

It crashes quite often when one clicks 'Apply' multiple times, but that happens in gtk-client option dialog otherwise too, so considering it separate issue -> Ready For Test

(file #22840)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 07 Oct 2014 02:50:11 AM UTC, comment #1:

bug #19884 would want use that slot now always free (ggz has been removed) for help, not settings.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 01 Jun 2014 08:11:48 PM UTC, original submission:

Attached patch adds "Local Settings" button to gtk-clients' main menu, to the slot reserved for ggz, but usually empty. In this initial version it's just alternative to ggz button. It opens local settings dialog.

The idea is that user should have possibility to change tileset, at least, before trying to enter game. Also disabling menu music should be possible without going to game and then changing the setting for future games only.

With the current version changing the tileset and then trying to leave the dialog crashes. This seems to be another colors not allocated when changing settings -problem.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22840:  GtkMainSettings-2.patch added by cazfi (3kB - text/x-diff)
file #20905:  GtkMainSettings.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 10 Nov 2014 10:44:26 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 07 Nov 2014 11:46:37 PM UTCcazfiAttached File-=>Added GtkMainSettings-2.patch, #22840
      StatusIn Progress=>Ready For Test
      Planned Release=>2.6.0
    Sun 01 Jun 2014 08:11:48 PM UTCcazfiAttached File-=>Added GtkMainSettings.patch, #20905
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup