patchFreeciv - Patches: patch #4783, [Metaticket] Savegame...

Show feedback again

patch #4783: [Metaticket] Savegame compatibility in 3.0

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat Jun 7 12:34:59 2014  
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Mon Oct 26 22:29:23 2015, comment #4:

Let's also mention in this ticket that it's practically blocking activities vector cleanup. Not a big deal (otherwise we would do it anyway), but something that savegame2.c and savegame3.c saves could be easily adjusted to handle (they already do the saving part of the activities order).

Marko Lindqvist <cazfi>
Project Administrator
Sun Oct 25 23:41:13 2015, comment #3:

Dropping savegame.c would be easier than fixing it in relation to bug #23614.

Marko Lindqvist <cazfi>
Project Administrator
Wed Dec 31 15:59:22 2014, comment #2:

> What's the motivation behind this? Just to reduce our maintenance burden?


Good point about the 2.3 release date. I had been thinking 2.2 (latest version of dropped support) date but of course that was all people had all the way until 2.3 was released. Let's keep the savegame.c around for now. We can drop it any time we want, but getting it back once removed is not so easy.

At some point we decided that at minimum we should support savegames from previous-1 version (3.0 should support 2.6 and 2.5). Otherwise people need to convert their savegames in steps.

You're more optimistic than I am about the 3.0 schedule. I'd expect 1.5-2 years in TRUNK + 1.5-2 years in stable branch -> 3-4 years before the release.

Marko Lindqvist <cazfi>
Project Administrator
Wed Dec 31 15:34:04 2014, comment #1:

> - savegame.c will be removed, dropping support for loading
> savegames older than those from freeciv-2.3

What's the motivation behind this? Just to reduce our maintenance burden?

Personally I haven't found maintaining savegame.c, nor fixing bugs in loading old savegames, to be a massive drag. I guess it'll become a little more tedious if we have three savegame backends.

Freeciv 2.3.0 was released a little over three years ago, and right now there are still active communities using 2.3. I guess it'll be at least another year or two before 3.0 (and this change) sees the light of day, but even so it feels like it might be a bit soon.

Debian squeeze (aka oldstable), still just about security supported via squeeze-lts, has Freeciv 2.2, so savefiles from squeeze won't be able to be loaded into 3.0.

(Does this cut us off from loading savefiles from the warserver community into standard Freeciv, or is that already impossible?)

Jacob Nevins <jtn>
Project Administrator
Sat Jun 7 12:34:59 2014, original submission:

Here's the plan about freeciv-3.0 savegame handling for which we've already been preparing during 2.6 cycle for example by introducing savecompat.[ch] module.

- savegame.c will be removed, dropping support for loading savegames older than those from freeciv-2.3
- savegame2.c will be copied as savegame3.c
- Saving part will be removed from savegame2.c, it happens in savegame3.c
- savegame2.c handles loading saves created by freeciv-2.3 - freeciv-2.6
- savegame3.c will load savegames created by freeciv-3.0 and later
- savegame3.c will be cleaned up accordingly (all the pre-3.0 compatibility stuff removed)

For division between savegame2.c and savegame3.c functionality to happen correctly, savegame3.c needs to be created almost immediately after branching 2.6 - before any 3.0-specific savegame functionality gets added (wrongly to savegame2.c)

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


   patch dependencies.

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Dec 31 15:27:12 2014jtnDependencies-=>Depends on patch #5591
    Fri Jul 11 01:10:05 2014cazfiDependencies-=>Depends on patch #4928
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup