patchFreeciv - Patches: patch #4835, Sdl2-client Coding Style...

 
 
Show feedback again

patch #4835: Sdl2-client Coding Style corrections

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 23 Jun 2014 12:17:27 AM UTC  
 
Category: client-sdl2Priority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 17 Dec 2014 04:12:16 AM UTC, comment #31:

wldgl.c style corrections

(file #23227)

Marko Lindqvist <cazfi>
Project Administrator
Wed 17 Dec 2014 03:56:10 AM UTC, SVN revision 27322:

Some Coding Style corrections for sdl2-client themespec.c, unistring.c,
widget_button.c, widget.c, widget_checkbox.c, widget_combo.c, widget_core.c,
widget_edit.c, widget_icon.c, widget_label.c, widget_scrollbar.c, and widget_window.c

See patch #4835

(Browse SVN revision 27322)

Marko Lindqvist <cazfi>
Project Administrator
Sun 14 Dec 2014 10:37:36 PM UTC, comment #29:

themespec.c, unistring.c, widget_button.c, widget.c, widget_checkbox.c, widget_combo.c, widget_core.c, widget_edit.c, widget_icon.c, widget_label.c, widget_scrollbar.c, and widget_window.c style corrections. After this the only c-file unhandled is wldlg.c.

(file #23180)

Marko Lindqvist <cazfi>
Project Administrator
Sun 14 Dec 2014 08:53:39 PM UTC, SVN revision 27305:

Some Coding Style corrections for sdl2-client repodlgs.c, spaceshipdlg.c, sprite.c,
themebackgrounds.c, themecolors.c, and themes.c.

See patch #4835

(Browse SVN revision 27305)

Marko Lindqvist <cazfi>
Project Administrator
Fri 12 Dec 2014 08:18:49 PM UTC, comment #27:

repodlgs.c, spaceshipdlg.c, sprite.c, themebackgrounds.c, themecolors.c, and themes.c style corrections.

(file #23163)

Marko Lindqvist <cazfi>
Project Administrator
Fri 12 Dec 2014 07:14:58 PM UTC, SVN revision 27278:

Some Coding Style corrections for sdl2-client optiondlg.c, pages.c,
and plrdlg.c.

See patch #4835

(Browse SVN revision 27278)

Marko Lindqvist <cazfi>
Project Administrator
Wed 10 Dec 2014 07:58:23 PM UTC, comment #25:

optiondlg.c, pages.c, and plrdlg.c corrections.

(file #23145)

Marko Lindqvist <cazfi>
Project Administrator
Wed 10 Dec 2014 07:21:37 PM UTC, SVN revision 27240:

Some Coding Style corrections for sdl2-client inteldlg.c, mapctrl.c, mapview.c,
menu.c, and messagewin.c.

See patch #4835

(Browse SVN revision 27240)

Marko Lindqvist <cazfi>
Project Administrator
Mon 08 Dec 2014 08:42:49 PM UTC, comment #23:

inteldlg.c, mapctrl.c, mapview.c, menu.c, and messagewin.c style corrections. For inteldg.c function headers are added, but for other files not (going to handle those in patch #2937)

(file #23099)

Marko Lindqvist <cazfi>
Project Administrator
Mon 08 Dec 2014 06:45:48 PM UTC, SVN revision 27212:

Some Coding Style corrections for sdl2-client gui_main.c, gui_mouse.c, gui_string.c,
gui_tilespec.c, and helpdlg.c.

See patch #4835

(Browse SVN revision 27212)

Marko Lindqvist <cazfi>
Project Administrator
Sat 06 Dec 2014 06:41:17 PM UTC, comment #21:

gui_main.c, gui_mouse.c, gui_string.c, gui_tilespec.c, and halpdlg.c style corrections.

(file #23049)

Marko Lindqvist <cazfi>
Project Administrator
Sat 06 Dec 2014 05:39:40 PM UTC, SVN revision 27201:

Some Coding Style corrections for sdl2-client colors.c, connectdlg.c, diplodlg.c,
finddlg.c, gotodlg.c, graphics.c, and gui_iconv.c.

See patch #4835

(Browse SVN revision 27201)

Marko Lindqvist <cazfi>
Project Administrator
Thu 04 Dec 2014 07:42:45 PM UTC, comment #19:

> colors.c, connectdlg.c, and diplodlg.c corrections. To be
> committed after 36h.


Doesn't apply cleanly any more. Updated patch applies, and has also finddlg.c, gotodlg.c, graphics.c, and gui_iconv.c handled

(file #23027)

Marko Lindqvist <cazfi>
Project Administrator
Sat 29 Nov 2014 10:17:03 AM UTC, comment #18:

colors.c, connectdlg.c, and diplodlg.c corrections. To be committed after 36h.

(file #23000)

Marko Lindqvist <cazfi>
Project Administrator
Sat 29 Nov 2014 08:59:22 AM UTC, SVN revision 27153:

Some Coding Style corrections for sdl2-client cityrep.c and cma_fe.c.

See patch #4835

(Browse SVN revision 27153)

Marko Lindqvist <cazfi>
Project Administrator
Mon 24 Nov 2014 04:35:13 AM UTC, comment #16:

cityrep.c and cma_fe.c corrections. To be committed after 36h.

(file #22958)

Marko Lindqvist <cazfi>
Project Administrator
Mon 24 Nov 2014 03:47:31 AM UTC, SVN revision 27119:

Some Coding Style corrections for sdl2-client chatline.c.

See patch #4835

(Browse SVN revision 27119)

Marko Lindqvist <cazfi>
Project Administrator
Thu 20 Nov 2014 11:44:07 PM UTC, comment #14:

chatline.c style corrections. To be committed after 36h.

(file #22935)

Marko Lindqvist <cazfi>
Project Administrator
Thu 20 Nov 2014 11:25:15 PM UTC, SVN revision 27092:

Some Coding Style corrections for sdl2-client canvas.c.

See patch #4835

(Browse SVN revision 27092)

Marko Lindqvist <cazfi>
Project Administrator
Mon 17 Nov 2014 05:43:46 AM UTC, comment #12:

canvas.c style corrections. To be committed after 36h.

(file #22905)

Marko Lindqvist <cazfi>
Project Administrator
Mon 17 Nov 2014 05:42:58 AM UTC, SVN revision 27057:

Some Coding Style corrections for sdl2-client action_dialog.c.

See patch #4835

(Browse SVN revision 27057)

Marko Lindqvist <cazfi>
Project Administrator
Wed 12 Nov 2014 06:55:30 AM UTC, comment #10:

action_dialog.c style corrections. To be committed after 36h.

(file #22880)

Marko Lindqvist <cazfi>
Project Administrator
Fri 22 Aug 2014 06:51:39 PM UTC, SVN revision 25997:

Some Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25997)

Marko Lindqvist <cazfi>
Project Administrator
Wed 20 Aug 2014 09:04:01 PM UTC, comment #8:

- Fixed compiler error

(file #21786)

Marko Lindqvist <cazfi>
Project Administrator
Fri 15 Aug 2014 11:42:42 PM UTC, comment #7:

- Next patch (to be committed after 36h)

(file #21744)

Marko Lindqvist <cazfi>
Project Administrator
Sun 03 Aug 2014 07:14:17 PM UTC, SVN revision 25800:

Some Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25800)

Marko Lindqvist <cazfi>
Project Administrator
Fri 01 Aug 2014 01:41:12 AM UTC, comment #5:

- Next patch (to be committed after 36h)

(file #21613)

Marko Lindqvist <cazfi>
Project Administrator
Sun 27 Jul 2014 09:42:03 AM UTC, SVN revision 25735:

Some Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25735)

Marko Lindqvist <cazfi>
Project Administrator
Sun 20 Jul 2014 11:04:21 PM UTC, comment #3:

- Next patch (to be committed after 36h)

(file #21488)

Marko Lindqvist <cazfi>
Project Administrator
Thu 26 Jun 2014 10:45:59 PM UTC, comment #2:

One set committed, leaving ticket open as there's probably more to come.

Marko Lindqvist <cazfi>
Project Administrator
Thu 26 Jun 2014 10:45:20 PM UTC, SVN revision 25287:

Set of Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25287)

Marko Lindqvist <cazfi>
Project Administrator
Mon 23 Jun 2014 12:17:27 AM UTC, original submission:

While I have been browsing sdl2-client code, I've routinely made some coding style corrections. Here is one such set.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23227:  Sdl2WldlgStyle.patch added by cazfi (9kB - text/x-diff)
file #23163:  Sdl2RepodlgsThemesStyle.patch.bz2 added by cazfi (13kB - application/x-bzip)
file #23145:  Sdl2OptiondlgPlrdlg.patch.bz2 added by cazfi (6kB - application/x-bzip)
file #23099:  Sdl2InteldlgMessagewinStyle.patch.bz2 added by cazfi (13kB - application/x-bzip)
file #23049:  Sdl2GuimainHelpdlgStyle.patch.bz2 added by cazfi (10kB - application/x-bzip)
file #23027:  Sdl2ColorsGuiiconvStyle.patch.bz2 added by cazfi (24kB - application/x-bzip)
file #22958:  Sdl2CityRepCmaStyle.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #22935:  Sdl2ChatlineStyle.patch added by cazfi (21kB - text/x-diff)
file #22905:  Sdl2CanvasStyle.patch added by cazfi (7kB - text/x-diff)
file #22880:  Sdl2ActionDlgStyle.patch.bz2 added by cazfi (5kB - application/x-bzip)
file #21786:  Sdl2MapctrlStyle-2.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #21744:  Sdl2MapctrlStyle.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #21613:  DialogsCoding.patch.bz2 added by cazfi (9kB - application/x-bzip)
file #21488:  Sdl2CityDlgClean.patch.bz2 added by cazfi (7kB - application/x-bzip)
file #21117:  Sdl2Style.patch.bz2 added by cazfi (8kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 18 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 17 Dec 2014 04:12:16 AM UTCcazfiAttached File-=>Added Sdl2WldlgStyle.patch, #23227
    Sun 14 Dec 2014 10:37:36 PM UTCcazfiAttached File-=>Added Sdl2ThemespecWidgetwindowStyle.patch.bz2, #23180
    Fri 12 Dec 2014 08:18:49 PM UTCcazfiAttached File-=>Added Sdl2RepodlgsThemesStyle.patch.bz2, #23163
    Wed 10 Dec 2014 07:58:23 PM UTCcazfiAttached File-=>Added Sdl2OptiondlgPlrdlg.patch.bz2, #23145
    Mon 08 Dec 2014 08:42:49 PM UTCcazfiAttached File-=>Added Sdl2InteldlgMessagewinStyle.patch.bz2, #23099
    Sat 06 Dec 2014 06:41:17 PM UTCcazfiAttached File-=>Added Sdl2GuimainHelpdlgStyle.patch.bz2, #23049
    Thu 04 Dec 2014 07:42:45 PM UTCcazfiAttached File-=>Added Sdl2ColorsGuiiconvStyle.patch.bz2, #23027
    Sat 29 Nov 2014 10:17:03 AM UTCcazfiAttached File-=>Added Sdl2ColorsConnDlgDiploDlgStyle.patch.bz2, #23000
    Mon 24 Nov 2014 04:35:13 AM UTCcazfiAttached File-=>Added Sdl2CityRepCmaStyle.patch.bz2, #22958
    Thu 20 Nov 2014 11:44:06 PM UTCcazfiAttached File-=>Added Sdl2ChatlineStyle.patch, #22935
    Mon 17 Nov 2014 05:43:46 AM UTCcazfiAttached File-=>Added Sdl2CanvasStyle.patch, #22905
    Wed 12 Nov 2014 06:55:30 AM UTCcazfiAttached File-=>Added Sdl2ActionDlgStyle.patch.bz2, #22880
    Wed 20 Aug 2014 09:04:01 PM UTCcazfiAttached File-=>Added Sdl2MapctrlStyle-2.patch.bz2, #21786
    Fri 15 Aug 2014 11:42:42 PM UTCcazfiAttached File-=>Added Sdl2MapctrlStyle.patch.bz2, #21744
    Fri 01 Aug 2014 01:41:12 AM UTCcazfiAttached File-=>Added DialogsCoding.patch.bz2, #21613
    Sun 20 Jul 2014 11:04:21 PM UTCcazfiAttached File-=>Added Sdl2CityDlgClean.patch.bz2, #21488
    Thu 26 Jun 2014 10:45:59 PM UTCcazfiStatusReady For Test=>In Progress
    Mon 23 Jun 2014 12:17:27 AM UTCcazfiAttached File-=>Added Sdl2Style.patch.bz2, #21117
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup