patchFreeciv - Patches: patch #4835, Sdl2-client Coding Style...

 
 
Show feedback again

patch #4835: Sdl2-client Coding Style corrections

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon Jun 23 00:17:27 2014  
 
Category: client-sdl2Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon Dec 22 22:09:45 2014, SVN revision 27385:

Some Coding Style corrections for sdl2-client headers

See patch #4835

(Browse SVN revision 27385)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Dec 20 03:32:11 2014, comment #33:

Style corrections to gui-sdl2 headers

(file #23240)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Dec 20 03:30:34 2014, SVN revision 27352:

Some Coding Style corrections for sdl2-client wldlg.c

See patch #4835

(Browse SVN revision 27352)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Dec 17 04:12:16 2014, comment #31:

wldgl.c style corrections

(file #23227)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Dec 17 03:56:10 2014, SVN revision 27322:

Some Coding Style corrections for sdl2-client themespec.c, unistring.c,
widget_button.c, widget.c, widget_checkbox.c, widget_combo.c, widget_core.c,
widget_edit.c, widget_icon.c, widget_label.c, widget_scrollbar.c, and widget_window.c

See patch #4835

(Browse SVN revision 27322)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Dec 14 22:37:36 2014, comment #29:

themespec.c, unistring.c, widget_button.c, widget.c, widget_checkbox.c, widget_combo.c, widget_core.c, widget_edit.c, widget_icon.c, widget_label.c, widget_scrollbar.c, and widget_window.c style corrections. After this the only c-file unhandled is wldlg.c.

(file #23180)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Dec 14 20:53:39 2014, SVN revision 27305:

Some Coding Style corrections for sdl2-client repodlgs.c, spaceshipdlg.c, sprite.c,
themebackgrounds.c, themecolors.c, and themes.c.

See patch #4835

(Browse SVN revision 27305)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Dec 12 20:18:49 2014, comment #27:

repodlgs.c, spaceshipdlg.c, sprite.c, themebackgrounds.c, themecolors.c, and themes.c style corrections.

(file #23163)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Dec 12 19:14:58 2014, SVN revision 27278:

Some Coding Style corrections for sdl2-client optiondlg.c, pages.c,
and plrdlg.c.

See patch #4835

(Browse SVN revision 27278)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Dec 10 19:58:23 2014, comment #25:

optiondlg.c, pages.c, and plrdlg.c corrections.

(file #23145)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Dec 10 19:21:37 2014, SVN revision 27240:

Some Coding Style corrections for sdl2-client inteldlg.c, mapctrl.c, mapview.c,
menu.c, and messagewin.c.

See patch #4835

(Browse SVN revision 27240)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Dec 8 20:42:49 2014, comment #23:

inteldlg.c, mapctrl.c, mapview.c, menu.c, and messagewin.c style corrections. For inteldg.c function headers are added, but for other files not (going to handle those in patch #2937)

(file #23099)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Dec 8 18:45:48 2014, SVN revision 27212:

Some Coding Style corrections for sdl2-client gui_main.c, gui_mouse.c, gui_string.c,
gui_tilespec.c, and helpdlg.c.

See patch #4835

(Browse SVN revision 27212)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Dec 6 18:41:17 2014, comment #21:

gui_main.c, gui_mouse.c, gui_string.c, gui_tilespec.c, and halpdlg.c style corrections.

(file #23049)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Dec 6 17:39:40 2014, SVN revision 27201:

Some Coding Style corrections for sdl2-client colors.c, connectdlg.c, diplodlg.c,
finddlg.c, gotodlg.c, graphics.c, and gui_iconv.c.

See patch #4835

(Browse SVN revision 27201)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Dec 4 19:42:45 2014, comment #19:

> colors.c, connectdlg.c, and diplodlg.c corrections. To be
> committed after 36h.


Doesn't apply cleanly any more. Updated patch applies, and has also finddlg.c, gotodlg.c, graphics.c, and gui_iconv.c handled

(file #23027)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Nov 29 10:17:03 2014, comment #18:

colors.c, connectdlg.c, and diplodlg.c corrections. To be committed after 36h.

(file #23000)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Nov 29 08:59:22 2014, SVN revision 27153:

Some Coding Style corrections for sdl2-client cityrep.c and cma_fe.c.

See patch #4835

(Browse SVN revision 27153)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Nov 24 04:35:13 2014, comment #16:

cityrep.c and cma_fe.c corrections. To be committed after 36h.

(file #22958)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Nov 24 03:47:31 2014, SVN revision 27119:

Some Coding Style corrections for sdl2-client chatline.c.

See patch #4835

(Browse SVN revision 27119)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Nov 20 23:44:07 2014, comment #14:

chatline.c style corrections. To be committed after 36h.

(file #22935)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Nov 20 23:25:15 2014, SVN revision 27092:

Some Coding Style corrections for sdl2-client canvas.c.

See patch #4835

(Browse SVN revision 27092)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Nov 17 05:43:46 2014, comment #12:

canvas.c style corrections. To be committed after 36h.

(file #22905)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Nov 17 05:42:58 2014, SVN revision 27057:

Some Coding Style corrections for sdl2-client action_dialog.c.

See patch #4835

(Browse SVN revision 27057)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Nov 12 06:55:30 2014, comment #10:

action_dialog.c style corrections. To be committed after 36h.

(file #22880)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Aug 22 18:51:39 2014, SVN revision 25997:

Some Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25997)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Aug 20 21:04:01 2014, comment #8:

- Fixed compiler error

(file #21786)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Aug 15 23:42:42 2014, comment #7:

- Next patch (to be committed after 36h)

(file #21744)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Aug 3 19:14:17 2014, SVN revision 25800:

Some Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25800)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Aug 1 01:41:12 2014, comment #5:

- Next patch (to be committed after 36h)

(file #21613)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jul 27 09:42:03 2014, SVN revision 25735:

Some Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25735)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jul 20 23:04:21 2014, comment #3:

- Next patch (to be committed after 36h)

(file #21488)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jun 26 22:45:59 2014, comment #2:

One set committed, leaving ticket open as there's probably more to come.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jun 26 22:45:20 2014, SVN revision 25287:

Set of Coding Style corrections for sdl2-client.

See patch #4835

(Browse SVN revision 25287)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Jun 23 00:17:27 2014, original submission:

While I have been browsing sdl2-client code, I've routinely made some coding style corrections. Here is one such set.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23240:  Sdl2HeadersStyle.patch.bz2 added by cazfi (9kB - application/x-bzip)
file #23227:  Sdl2WldlgStyle.patch added by cazfi (9kB - text/x-diff)
file #23163:  Sdl2RepodlgsThemesStyle.patch.bz2 added by cazfi (13kB - application/x-bzip)
file #23145:  Sdl2OptiondlgPlrdlg.patch.bz2 added by cazfi (6kB - application/x-bzip)
file #23099:  Sdl2InteldlgMessagewinStyle.patch.bz2 added by cazfi (13kB - application/x-bzip)
file #23049:  Sdl2GuimainHelpdlgStyle.patch.bz2 added by cazfi (10kB - application/x-bzip)
file #23027:  Sdl2ColorsGuiiconvStyle.patch.bz2 added by cazfi (24kB - application/x-bzip)
file #22958:  Sdl2CityRepCmaStyle.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #22935:  Sdl2ChatlineStyle.patch added by cazfi (21kB - text/x-diff)
file #22905:  Sdl2CanvasStyle.patch added by cazfi (7kB - text/x-diff)
file #22880:  Sdl2ActionDlgStyle.patch.bz2 added by cazfi (5kB - application/x-bzip)
file #21786:  Sdl2MapctrlStyle-2.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #21744:  Sdl2MapctrlStyle.patch.bz2 added by cazfi (8kB - application/x-bzip)
file #21613:  DialogsCoding.patch.bz2 added by cazfi (9kB - application/x-bzip)
file #21488:  Sdl2CityDlgClean.patch.bz2 added by cazfi (7kB - application/x-bzip)
file #21117:  Sdl2Style.patch.bz2 added by cazfi (8kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 23 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Dec 22 22:10:12 2014cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat Dec 20 03:32:11 2014cazfiAttached File-=>Added Sdl2HeadersStyle.patch.bz2, #23240
      StatusIn Progress=>Ready For Test
    Wed Dec 17 04:12:16 2014cazfiAttached File-=>Added Sdl2WldlgStyle.patch, #23227
    Sun Dec 14 22:37:36 2014cazfiAttached File-=>Added Sdl2ThemespecWidgetwindowStyle.patch.bz2, #23180
    Fri Dec 12 20:18:49 2014cazfiAttached File-=>Added Sdl2RepodlgsThemesStyle.patch.bz2, #23163
    Wed Dec 10 19:58:23 2014cazfiAttached File-=>Added Sdl2OptiondlgPlrdlg.patch.bz2, #23145
    Mon Dec 8 20:42:49 2014cazfiAttached File-=>Added Sdl2InteldlgMessagewinStyle.patch.bz2, #23099
    Sat Dec 6 18:41:17 2014cazfiAttached File-=>Added Sdl2GuimainHelpdlgStyle.patch.bz2, #23049
    Thu Dec 4 19:42:45 2014cazfiAttached File-=>Added Sdl2ColorsGuiiconvStyle.patch.bz2, #23027
    Sat Nov 29 10:17:03 2014cazfiAttached File-=>Added Sdl2ColorsConnDlgDiploDlgStyle.patch.bz2, #23000
    Mon Nov 24 04:35:13 2014cazfiAttached File-=>Added Sdl2CityRepCmaStyle.patch.bz2, #22958
    Thu Nov 20 23:44:06 2014cazfiAttached File-=>Added Sdl2ChatlineStyle.patch, #22935
    Mon Nov 17 05:43:46 2014cazfiAttached File-=>Added Sdl2CanvasStyle.patch, #22905
    Wed Nov 12 06:55:30 2014cazfiAttached File-=>Added Sdl2ActionDlgStyle.patch.bz2, #22880
    Wed Aug 20 21:04:01 2014cazfiAttached File-=>Added Sdl2MapctrlStyle-2.patch.bz2, #21786
    Fri Aug 15 23:42:42 2014cazfiAttached File-=>Added Sdl2MapctrlStyle.patch.bz2, #21744
    Fri Aug 1 01:41:12 2014cazfiAttached File-=>Added DialogsCoding.patch.bz2, #21613
    Sun Jul 20 23:04:21 2014cazfiAttached File-=>Added Sdl2CityDlgClean.patch.bz2, #21488
    Thu Jun 26 22:45:59 2014cazfiStatusReady For Test=>In Progress
    Mon Jun 23 00:17:27 2014cazfiAttached File-=>Added Sdl2Style.patch.bz2, #21117
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup