patchFreeciv - Patches: patch #4902, Unit veteran level requirement type

 
 
Show feedback again

patch #4902: Unit veteran level requirement type

Submitted by:  Sveinung Kvilhaugsvik <sveinung>
Submitted on:  Fri 04 Jul 2014 02:16:07 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 27 Aug 2014 08:31:26 AM UTC, SVN revision 26069:

Add MinVeteran requirement.

Requested by Sveinung Kvilhaugsvik (sveinung@gna) and myself.

See gna patch #4902.

(Browse SVN revision 26069)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 25 Aug 2014 04:23:41 PM UTC, comment #2:

Patch adds MinVeteran requirement, taking a numeric veteran level.
I haven't pursued any of the other ideas in comment #0.

(The autogenerated help is a bit weak since it has to talk about numeric veteran levels. I can't really see that it can talk about named ones given their unit type dependence. It might be cosmetically nicer to talk in ordinals, but that requires i18n infrastructure that we don't have.)

(file #21837)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 05 Jul 2014 10:51:59 AM UTC, comment #1:

Also to limit the maximum veteran level, per patch #3402.

I assume this would be a MinLevel type requirement, that would match units of a given level and above. (Matching on a specific requirement could be done by adding a present=FALSE requirement for the next level up.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 04 Jul 2014 02:16:07 PM UTC, original submission:

Some potential uses:

  • Require a unit to be a veteran before allowing it to do a certain action
  • Veteran level based recover speed (Unit_Recover and HP_Regen)
  • Unhardcode veteran level price influence via the effect Unit_Bribe_Cost_Pct?
  • Give the veteran level move bonus via the effect Move_Bonus in stead of veteran_move_bonus?

Remember: Different unit types can have different veteran systems. The number of veteran levels can be different. A veteran level name can appear in multiple veteran systems or in only one system.

Sveinung Kvilhaugsvik <sveinung>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21837:  trunk-req-minveteran.patch added by jtn (9kB - text/x-diff - trunk r26039)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by sveinung (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 27 Aug 2014 08:36:50 AM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Mon 25 Aug 2014 04:23:41 PM UTCjtnAttached File-=>Added trunk-req-minveteran.patch, #21837
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
      Planned Release=>2.6.0
    Sat 05 Jul 2014 10:51:59 AM UTCjtnSummaryUnit veteran level requirment type=>Unit veteran level requirement type
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup