patchFreeciv - Patches: patch #5011, civ2civ3: default to...

 
 
Show feedback again

patch #5011: civ2civ3: default to team_pooled_research=FALSE

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 02 Aug 2014 12:04:50 PM UTC  
 
Category: rulesetsPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 16 Nov 2014 02:10:15 PM UTC, comment #11:

It is ok to me.

David Fernandez <bardo>
Sat 15 Nov 2014 05:07:41 PM UTC, comment #10:

Removing release target.

My inclination is to drop this now that the underlying bugs have gone away, but I leave final decision to bardo as ruleset author.

Jacob Nevins <jtn>
Project Administrator
Mon 06 Oct 2014 11:17:10 PM UTC, comment #9:

Right, but we now have a free choice of default rather than being constrained by bugs. So this becomes a "what's a sensible default" question, and I'm not sure civ2civ3 is special compared to other rulesets like the classic one.

Jacob Nevins <jtn>
Project Administrator
Sun 05 Oct 2014 08:32:51 PM UTC, comment #8:

I agree it could be disabled by default. I actually use to play without team pooled research.

David Fernandez <bardo>
Sun 05 Oct 2014 08:28:24 PM UTC, comment #7:

> A few tech fixes have been committed to S2_5 since this
> comment. How about now -- do we still need to disable
> team_pooled_research in S2_5 civ2civ3?


I don't think they are known bugs about team pooled research enabled/disabled in S2_5. However, it doesn't mean that it would be a bad idea to disable it by default.

pepeto <pepeto>
Project Member
Sun 05 Oct 2014 01:26:24 PM UTC, comment #6:

>> So maybe this ticket's redundant?
> I don't think so. But I am currently thinking that there is
> maybe a way to fix random tech issues in S2_4 and S2_5.

A few tech fixes have been committed to S2_5 since this comment. How about now -- do we still need to disable team_pooled_research in S2_5 civ2civ3?

Jacob Nevins <jtn>
Project Administrator
Mon 25 Aug 2014 03:03:22 PM UTC, comment #5:

> So maybe this ticket's redundant?


I don't think so. But I am currently thinking that there is maybe a way to fix random tech issues in S2_4 and S2_5.

pepeto <pepeto>
Project Member
Sun 24 Aug 2014 09:31:48 AM UTC, comment #4:

> We know that that doesn't work well with
> team_pooled_research=TRUE, and probably won't be fixed until
> 2.6.0 (bug #22058).

In fact pepeto has committed fixes for that bug to S2_4/S2_5. So maybe this ticket's redundant? I haven't checked whether any of the other research bugs only fixed on trunk will cause trouble.

Jacob Nevins <jtn>
Project Administrator
Sat 09 Aug 2014 04:08:59 PM UTC, comment #3:

New patch where I use TRUE and FALSE instead of "ENABLED" and "DISABLED" for all settings, except for "borders" that seems to require a String (not boolean) value.

Patch for rev25768, where bug #22446 was already applied.

(file #21683, file #21684)

David Fernandez <bardo>
Sat 02 Aug 2014 07:01:24 PM UTC, comment #2:

Patch to disable team_pooled_research by default for trunk.
Option locked (and commented) for v2.5.

I also simplified the description of the ruleset because I think it is no longer accurate. Removed this part:

>Adapted for single player, with AI less aggressive at start, but more challenging at the end.

The latest changes to the rules, specially the tech upkeep, and the increased unit upkeep costs, have made the AI less challenging at the end of the game. I do not see fair that these rules claim that AI is more challenging than classic rules, even if I think it was true for some versions.
(I never know if I should open a different ticket for this kind of text changes).

(file #21632, file #21633)

David Fernandez <bardo>
Sat 02 Aug 2014 01:51:18 PM UTC, comment #1:

I like the idea to lock it. Maybe with a sort comment in the same line of game.ruleset, so possible modders know why is locked.

David Fernandez <bardo>
Sat 02 Aug 2014 12:04:50 PM UTC, original submission:

Civ2civ3 uses tech upkeep.
We know that that doesn't work well with team_pooled_research=TRUE, and probably won't be fixed until 2.6.0 (bug #22058).
To allow reliable civ2civ3 team games in 2.5.x, we should probably change the ruleset default to team_pooled_research=FALSE. (And maybe lock it?)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by bardo (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  • -unavailable- added by jtn (civ2civ3 maintainer)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Nov 2014 05:07:41 PM UTCjtnPlanned Release2.5.0, 2.6.0=>
    Sat 09 Aug 2014 04:08:59 PM UTCbardoAttached File-=>Added civ2civ3-team_pooled_research-trunk-2.patch, #21683
      Attached File-=>Added civ2civ3-team_pooled_research-S2_5-2.patch, #21684
    Sat 02 Aug 2014 07:01:24 PM UTCbardoAttached File-=>Added civ2civ3-team_pooled_research-trunk.patch, #21632
      Attached File-=>Added civ2civ3-team_pooled_research-S2_5.patch, #21633
    Sat 02 Aug 2014 12:05:07 PM UTCjtnDependencies-=>Depends on patch #5010
    Sat 02 Aug 2014 12:04:50 PM UTCjtnCarbon-Copy-=>Added bardo
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup