patchFreeciv - Patches: patch #5046, Call gained_control / lost_control...

 
 
Show feedback again

patch #5046: Call gained_control / lost_control for /away player

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri Aug 15 22:03:38 2014  
 
Category: aiPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.4, 2.5.0-beta2, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat Oct 11 11:44:20 2014, comment #5:

dai_assess_danger_player() would not get called before next turn change, i.e., the danger considerations are bogus for the rest of the turn player goes /away.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Oct 11 11:14:34 2014, comment #4:

For existing AIs: this is obviously important for threaded AI. For classic AI it boils down to dai_assess_danger_player() not getting called. Does that have a visible effect, or does it get called sooner or later by other means?
(For release notes.)

Jacob Nevins <jtn>
Project Administrator
Wed Aug 20 21:58:18 2014, SVN revision 25966:

Call AI callbacks gained_control and lost_control when AI gets ot loses control of /away player.

See patch #5046

(Browse SVN revision 25966)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Aug 20 21:58:14 2014, SVN revision 25965:

Call AI callbacks gained_control and lost_control when AI gets ot loses control of /away player.

See patch #5046

(Browse SVN revision 25965)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Aug 20 21:58:09 2014, SVN revision 25964:

Call AI callbacks gained_control and lost_control when AI gets ot loses control of /away player.

See patch #5046

(Browse SVN revision 25964)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Aug 15 22:03:38 2014, original submission:

Call AI callbacks gained_control and lost_control when AI gots/loses control of /away player.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21741:  AwayCallbacks.patch added by cazfi (2kB - text/x-diff)
file #21742:  AwayCallbacks-S2_5.patch added by cazfi (905B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Aug 20 21:58:30 2014cazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri Aug 15 22:03:39 2014cazfiAttached File-=>Added AwayCallbacks.patch, #21741
      Attached File-=>Added AwayCallbacks-S2_5.patch, #21742
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup