patchFreeciv - Patches: patch #5100, Send player tech_upkeep and real...

 
 
Show feedback again

patch #5100: Send player tech_upkeep and real researching_cost to the client (stable branches)

Submitted by:  pepeto <pepeto>
Submitted on:  Mon Aug 25 19:44:17 2014  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: 2.4.4, 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat Sep 27 10:44:39 2014, comment #7:

Python 3 incompatibility raised as new ticket bug #22705.

Jacob Nevins <jtn>
Project Administrator
Fri Sep 26 17:32:37 2014, comment #6:

This patch is broken when compiled using python3.

Two lines in common/packets.def
UINT32 researching_cost; add-cap(tech_cost)
UINT16 tech_upkeep; add-cap(tech_cost)
do not compile.

In Python3 the 'dict_keys' object does not support indexing.

This is the second recent use of this structure in common/packets.def. Before these patches python3 works (6 weeks ago). I also posted this comment on the first recent use http://gna.org/patch/?4351.

Anonymous
Fri Sep 5 08:34:55 2014, SVN revision 26231:

Send player tech_upkeep to the clients.
Send the real researching_cost to the clients.
Refresh the science surplus of the players in case of the research
is team-pooled.

See gna patch #5100

(Browse SVN revision 26231)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri Sep 5 08:34:49 2014, SVN revision 26230:

Send player tech_upkeep to the clients.
Send the real researching_cost to the clients.
Refresh the science surplus of the players in case of the research
is team-pooled.

See gna patch #5100

(Browse SVN revision 26230)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Sep 3 12:30:52 2014, comment #3:

New version:

  • fix GUI update when handling the PLAYER_INFO packet.

(file #22007, file #22008)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Sep 1 14:55:26 2014, comment #2:

Updated version, including fix for bug #21299.

(file #21983, file #21984)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue Aug 26 14:57:12 2014, comment #1:

Fixed A_UNSET research cost.

(file #21885, file #21886)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Aug 25 19:44:17 2014, original submission:

Mostly a backport of the patch I made for bug #22062.

pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Digest:
   bug dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 16 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Oct 6 23:00:09 2014jtnSummarySend player tech_upkeep and real researching_cost to the client=>Send player tech_upkeep and real researching_cost to the client (stable branches)
    Fri Sep 5 08:35:08 2014pepetoStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Wed Sep 3 12:30:52 2014pepetoAttached File-=>Added S2_4_network_capability_tech_cost4.patch, #22007
      Attached File-=>Added S2_5_network_capability_tech_cost4.patch, #22008
    Mon Sep 1 14:55:26 2014pepetoAttached File-=>Added S2_4_network_capability_tech_cost3.patch, #21983
      Attached File-=>Added S2_5_network_capability_tech_cost3.patch, #21984
    Sun Aug 31 13:42:47 2014pepetoDependencies-=>Depends on bugs #21299
    Tue Aug 26 14:57:37 2014pepetoAttached File-=>Added S2_4_network_capability_tech_cost2.patch, #21887
    Tue Aug 26 14:57:25 2014pepetoAttached File#21886=>Removed
    Tue Aug 26 14:57:22 2014pepetoAttached File#21854=>Removed
    Tue Aug 26 14:57:12 2014pepetoAttached File-=>Added S2_5_network_capability_tech_cost2.patch, #21885
      Attached File-=>Added S2_4_base_total_bulbs_required.patch, #21886
    Mon Aug 25 19:46:22 2014pepetoDependencies-=>patch #4726 is dependent
    Mon Aug 25 19:44:17 2014pepetoAttached File-=>Added S2_5_network_capability_tech_cost.patch, #21853
      Attached File-=>Added S2_4_player_tech_upkeep.patch, #21854
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup