patchFreeciv - Patches: patch #5468, German Empire (1871-1914) nation

 
 
Show feedback again

patch #5468: German Empire (1871-1914) nation

Submitted by:  Ferdi <sketlux>
Submitted on:  Thu Nov 27 13:56:55 2014  
Votes:  100  
 
Category: rulesetsPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: J.M. Maalderink <mixcoatl>Open/Closed: Open
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed Aug 24 14:29:12 2016, comment #5:

Based on a comment in patch #7613 don't hold your breath for 2.5.6, but this business should be really part of 2.6.0 (or any 2.6.0 beta or RC = release candidate before 2.6.0, excluding the already existing unoffocial 2.6.0-beta0 test versions.)

No showstopper, but holy_roman cannot fight with german_empire, and eastgerman also won't do. At some point in time that should be fixed automatically (= some script computing missing conflicts, plus manual interventions for known cities with different names in different epochs.)

Frank <dunnoob>
Thu Aug 18 20:49:11 2016, comment #4:

Changed the doc name to german_empire.ruleset. She has to live with the flag, after all its Yemens
flag just turned upside-down... She was the only female leader I could think of although she didnt make it very far.

Conflict nations added. I focused too much on minorities that I forgot the most obvious choice Germany
and of course the hanseatic scepticism towards Prussia...

Ferdi <sketlux>
Thu Aug 18 14:46:51 2016, comment #3:

Wrong file name POUTFILES.in.patch replaced by POTFILES.in.patch (same content)

(file #28402)

Frank <dunnoob>
Tue Aug 16 02:10:09 2016, comment #2:

The german_empire.txt should obviously go to german_empire.ruleset (and hopefully Rosa Luxemburg accepts the flag, but her choices are somewhat limited ;-)

You could add german under conflicts_with + civilwar-nations. And maybe a few others like hansa. Maybe the server automatically avoids "obvious" conflicts (overlapping city names), or that's a not yet reported wish.

Based on http://freeciv.wikia.com/wiki/Nations#How_to_introduce_your_nation_ruleset_file I've added patches for translations/nations/POTFILES.in and data/default/nationlist.ruleset.

I can't tell if the ruleset needs a...

...or not, it might be limited to core nations (and wasn't documented on the Wiki page). Four related patches affecting the flags ended up in patch #7613 (depending on this patch).

Adding a flag to Freeciv is slightly more complex than "write a working device driver" or other trivial tasks. :-P

(file #28340, file #28341)

Frank <dunnoob>
Sun Aug 14 02:48:04 2016, comment #1:

Cf. http://freeciv.wikia.com/wiki/File:German_empire.svg (attached)

(file #28295)

Frank <dunnoob>
Thu Nov 27 13:56:55 2014, original submission:
Ferdi <sketlux>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29479:  german_empire.ruleset.txt added by sketlux (7kB - text/plain - small correction of the ruleset...)
file #28404:  german_empire.ruleset.txt added by sketlux (7kB - text/plain - Changed the doc name to german_empire.ruleset. She has to live with the flag, after all its Yemens flag just turned upside-down... She was the only female leader I could think of although she didnt make it very far. Conflict nations added. I focused to)
file #28402:  POTFILES.in.patch added by dunnoob (353B - text/x-diff)
file #28340:  nationlist.ruleset.patch added by dunnoob (404B - text/x-diff)
file #28341:  POUTFILES.in.patch added by dunnoob (353B - text/x-diff)
file #28304:  german_empire.txt added by sketlux (7kB - text/plain - Glitch: It should be of course German Empire (1871-1918) and not ...-1914).)
file #28295:  german_empire.svg added by dunnoob (233B - image/svg+xml - PD is GPL compatible)
file #28282:  german_empire.png added by sketlux (351B - image/png)

 

Depends on the following items: None found

Items that depend on this one

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by dunnoob (Updated the item)
  • -unavailable- added by sketlux (Voted in favor of this item)
  • -unavailable- added by sveinung (Updated the item)
  • -unavailable- added by sketlux (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 100 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 17 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Nov 21 20:24:36 2016sketluxAttached File-=>Added german_empire.ruleset.txt, #29479
    Sun Aug 21 14:34:31 2016jtnDependencies-=>patch #7613 is dependent
    Thu Aug 18 20:47:11 2016sketluxAttached File-=>Added german_empire.ruleset.txt, #28404
    Thu Aug 18 14:46:51 2016dunnoobAttached File-=>Added POTFILES.in.patch, #28402
    Tue Aug 16 02:10:09 2016dunnoobAttached File-=>Added nationlist.ruleset.patch, #28340
      Attached File-=>Added POUTFILES.in.patch, #28341
    Sun Aug 14 10:43:55 2016sketluxAttached File-=>Added german_empire.txt, #28304
    Sun Aug 14 02:48:04 2016dunnoobAttached File-=>Added german_empire.svg, #28295
    Sat Aug 13 12:27:29 2016sketluxAttached File-=>Added german_empire-large.png, #28280
      Attached File-=>Added german_empire-shield.png, #28281
      Attached File-=>Added german_empire.png, #28282
      Attached File-=>Added german_empire-shield-large.png, #28283
    Tue Feb 2 10:22:41 2016sketluxCarbon-Copy-=>Added sketlux
    Tue Oct 20 01:55:31 2015sveinungCategoryNone=>rulesets
      Assigned toNone=>mixcoatl
    Thu Nov 27 13:56:55 2014sketluxAttached File-=>Added German Empire (1871-1914) nation.txt, #22987
      Attached File-=>Added 800px-Flag_of_the_German_Empire.svg.png, #22988
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup