patchFreeciv - Patches: patch #5862, Show extra owner in tile info popup

 
 
Show feedback again

patch #5862: Show extra owner in tile info popup

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Mon Feb 23 23:40:44 2015  
 
Category: clientPriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Aug 22 20:00:44 2016, comment #4:

Given that eowner applies to all infra, I see the current patch as actually suitable for commit (haven't tested if it still applies). It's true that most extras do not care about owner at all, but figuring out if that's the case with all the extras on a tile isn't likely to happen in this ticket.

Marko Lindqvist <cazfi>
Project Administrator
Tue Feb 24 00:05:49 2015, comment #3:

> I clearly need to remind myself what the extra ownership
> semantics we ended up with were.

...probably as part of documenting them in ruleset comments.

Jacob Nevins <jtn>
Project Administrator
Tue Feb 24 00:05:22 2015, comment #2:

I clearly need to remind myself what the extra ownership semantics we ended up with were.

What I'm trying to avoid is spurious "Infrastructure: Road [French, team Team 0]", where ownership of a road extra doesn't actually confer any bonus to the owner. ...maybe I should just check for vision bonus? (Given that I'm suppressing owner==eowner, border-granting bases would never display this text anyway.)

Jacob Nevins <jtn>
Project Administrator
Mon Feb 23 23:57:14 2015, comment #1:

> Might also be useful if an ownership-granting extra is hidden by
> another one?


It doesn't need to be ownership-granting one, all of them are owned by the extra owner. You are thinking in terms of 2.5 and earlier border-claiming hack to make buoys to work.

> I suspect the answer is to maintain an invariant that
> extras_owner is only non-NULL iff there is a suitable base on
> the tile.


That would change scenario scripting (bases appearing without workers finishing them) semantics. The idea of the current implementation is that e.g. bases added to a city (after city has been founded) get owned by the city owner by default.

Marko Lindqvist <cazfi>
Project Administrator
Mon Feb 23 23:40:44 2015, original submission:

When owned extras are likely to have the ShowFlag display option, it would be useful to include textual extra owner information in the popup, if different from tile owner information.
(Might also be useful if an ownership-granting extra is hidden by another one? Not sure.)

The attached gives some idea of what I'd do. With file #23902 it yields "Infrastructure: Buoy [Mali, team Team 0]".

However, I suspect it's not ready for commit. It doesn't try to work out if there's a suitable base, and looking at the eowner information in a savefile, I think extras_owner is getting set quite liberally -- I think it's set on a tile whenever a city is founded there, for instance, despite lack of bases.
(I suspect the answer is to maintain an invariant that extras_owner is only non-NULL iff there is a suitable base on the tile.)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23905:  S2_6-popup-show-base-owner-wip.patch added by jtn (743B - text/x-patch - S2_6 r28297)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Aug 22 20:00:44 2016cazfiStatusNone=>Ready For Test
    Mon Feb 23 23:40:44 2015jtnAttached File-=>Added S2_6-popup-show-base-owner-wip.patch, #23905
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup