patchFreeciv - Patches: patch #7500, Make client gui_type available to...

 
 
Show feedback again

patch #7500: Make client gui_type available to server Lua script (and hence tutorial)

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun Jul 24 11:11:20 2016  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun Aug 21 13:52:05 2016, comment #2:

> Or in other words, if a script needs to know the client it
> should get that info locally from the client.

The tutorial script runs on the server.

Jacob Nevins <jtn>
Project Administrator
Sat Aug 6 11:59:38 2016, comment #1:

I think the server should not know the client, tileset, music, sounds, or sound plugin of a player. And players including AIs should not know any server details, as long as the versions are compatible, and excluding visible settings plus ruleset.

Or in other words, if a script needs to know the client it should get that info locally from the client. Likewise it could determine the tileset, music, sounds, sound plugin, theme, language (etc.) locally, because that's no server and no connection business.

Frank <dunnoob>
Sun Jul 24 11:11:20 2016, original submission:

Currently, the tutorial contains text about the UI that is not quite right for all clients. It's generally right about Gtk and not about Qt (and probably hopeless for SDL).

If the Lua script had access to the gui_type, it could adapt its text.

Clients already send their gui_type to the server in PACKET_CLIENT_INFO, but the server doesn't store it.

Should presumably be made available through Lua Connection object.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by dunnoob (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup