patchFreeciv - Patches: patch #7613, Flags clean-up

 
 
Show feedback again

patch #7613: Flags clean-up

Submitted by:  Frank <dunnoob>
Submitted on:  Tue Aug 16 00:48:30 2016  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed Aug 24 16:56:56 2016, comment #5:

Fourth part of what I had in mind, rename svg.svg (sic!) to vincentian.svg later, after this patch #7613 made it into SVN, and after two affected SVGs in http://freeciv.wikia.com/wiki/Category:Edit_requests are renamed by an active Wiki admin. Sadly my attempt to reactivate inactive admins for Wiki maintenance failed so far, cf. http://freeciv.wikia.com/wiki/Category:ETMO

Frank <dunnoob>
Wed Aug 24 13:08:33 2016, comment #4:

The purpose of this patch is to finish the german empire efforts in patch #5468 started 2014 and now ready from my POV. It also adds an (unused) Hongkong flag requested in the Wiki in 2007, and adds an (unused) Danzig flag by J.M. Maalderink in http://download.gna.org/freeciv/contrib/nations/danzig.patch (2010). The patch re-inserts the "lost" (unused) old Myanmar flag in the relevant makefiles etc.

It activates nine unused flags for uses in non-standard or modified nations. The tenth and last unused flag "unknown" is already activated, and that's as it should be for all unused flags in data/flags, e.g., I'd like to use the unused NATO flag for http://freeciv.wikia.com/wiki/Nations/native instead of stealing the Aleut flag (that works but it's not really a good hack.)

The whole unused flag business does not affect any nation you'd find in a save game, but the german empire would be a new nation. If that's impossible for 2.5.6 (why?) it could of course also be handled in 2.6.0-beta1, please check path #5468 for the details (not my idea, I just added it to some anyway required patches for the "unused" clean-up).

The first part of the other patches I have in mind for later are lots of already fixed invalid SVGs, lots of not yet fixed SVGs, and apparently the convert_png procedure is not automatical, therefore I have to check all pending SVG patches again and roll my own convert_png equivalent if old and new SVG are visually different. Presumably I'll only tackle NATO, because I care about the natives. As long as the SVG is valid and some PNGs exist updating the PNGs can be done on demand (different color in SVG counts as "demand" from my POV.)

The second part of other patches I have in mind for later is collected in bug #24982. The third and last part is the trivial patch #7435, get rid of four non-existing flags erroneously mentioned as alternative in four nation rulesets.

Frank <dunnoob>
Sun Aug 21 14:33:27 2016, comment #3:

What is the purpose of this ticket?

It's not clear to me what exactly you'd like us to do, or why.

> Please add patch #7613 and its dependencies patch #7612, patch #7609, patch #5468 to task #7992

Task #7792 is 2.5.6. These patches seem to be about nations that aren't currently in svn (unlike the series of tickets like patch #7393 that are about flags in svn, but not apparently the subject of this ticket).
We won't be adding any new nations to a stable branch, because of savegame compatibility.

> because it blocks all other pending patches related to flags/nations

I'm not sure which ones you have in mind.

Jacob Nevins <jtn>
Project Administrator
Sat Aug 20 01:47:35 2016, comment #2:

Please add patch #7613 and its dependencies patch #7612, patch #7609, patch #5468 to task #7992 as "very much wanted", because it blocks all other pending patches related to flags/nations:

Arguably everything else is still incomplete, because nobody bothered to add patches for the 3+5 general files (4 * flags spec, 1 * nationlist, 1 or 2 Makefile.am, 1 * POTFILE.in) or the 4 PNGs per flag/nation, but it would get messy if anybody tries this now.

Frank <dunnoob>
Tue Aug 16 06:13:53 2016, comment #1:

I've forgotten the trunk/data/flags/Makefile.am -- apparently this is not yet created automatically, unlike trunk/data/nation/Makefile.am (?)

Also see http://freeciv.wikia.com/wiki/Talk:Introduction_tasks :-P

(file #28343)

Frank <dunnoob>
Tue Aug 16 00:48:30 2016, original submission:

Depends on patch #5468, patch #7609, and patch #7612: Adds german_empire, hongkong, and danzig to 2*2 spec files (credits in flags.spec).

All unused alternative flags are moved to the end of the list and un-commented; this permits to actually use these flags with normal tilesets in ad hoc nations. The unknown flag is (alphabetically) the last unused alternative flag.

The old Myanmar flag was AWOL, I added it as unused, the SVG + PNGs already exist. Corresponding flag report:

The missing flags are fixed (=removed) in patch #7435.

Frank <dunnoob>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28343:  Makefile.am.patch added by dunnoob (4kB - text/x-diff)
file #28336:  flags.spec.patch added by dunnoob (5kB - text/x-diff)
file #28337:  flags-large.spec.patch added by dunnoob (4kB - text/x-diff)
file #28338:  shields.spec.patch added by dunnoob (4kB - text/x-diff)

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by dunnoob (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Aug 21 14:34:30 2016jtnDependencies-=>Depends on patch #5468
    Sun Aug 21 14:34:16 2016jtnDependencies-=>Depends on patch #7609
    Sun Aug 21 14:33:57 2016jtnDependencies-=>Depends on patch #7612
    Tue Aug 16 06:13:53 2016dunnoobAttached File-=>Added Makefile.am.patch, #28343
    Tue Aug 16 00:48:30 2016dunnoobAttached File-=>Added flags.spec.patch, #28336
      Attached File-=>Added flags-large.spec.patch, #28337
      Attached File-=>Added shields.spec.patch, #28338
      Attached File-=>Added shields-large.spec.patch, #28339
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup