patchWarzone 2100 Project - Patches: patch #1082, Fix AL_INVALID_NAME bug

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

patch #1082: Fix AL_INVALID_NAME bug

Submitted by:  Per I. Mathisen <per>
Submitted on:  Tue 08 Jul 2008 12:33:37 PM UTC  
 
Category: FixPriority: 7 - High
Status: Works For MePrivacy: Public
Assigned to: Giel van Schijndel <muggenhor>Open/Closed: Open
Planned Release: None

(Jump to the original submission Jump to the original submission)

Mon 22 Sep 2008 06:27:55 AM UTC, comment #6:

No.

Per I. Mathisen <per>
Project Administrator
Mon 22 Sep 2008 03:38:09 AM UTC, comment #5:

Are you still working on this?

Bugs Buggy <buginator>
Project Administrator
Tue 08 Jul 2008 06:16:14 PM UTC, comment #4:

Another fix. This ensures that when the queue item is removed, we also remove it from the list in audio.c.

(file #4537)

Per I. Mathisen <per>
Project Administrator
Tue 08 Jul 2008 05:12:05 PM UTC, SVN revision 5425:

Add an error check to patch #1082: Fix AL_INVALID_NAME bug, to catch the
currently impossible case of the sample not being in the active list.

(Browse SVN revision 5425)

Per I. Mathisen <per>
Project Administrator
Tue 08 Jul 2008 04:12:16 PM UTC, SVN revision 5422:

patch #1082: Fix AL_INVALID_NAME bug, sans one no good assert.

(Browse SVN revision 5422)

Per I. Mathisen <per>
Project Administrator
Tue 08 Jul 2008 02:42:40 PM UTC, comment #1:

Improved patch that does not add another AL_INVALID_NAME bug of its own, attached. Also I noticed that the same bug crops up in several other places in the code, and OpenAL-soft reports that we leak buffers.

(file #4536)

Per I. Mathisen <per>
Project Administrator
Tue 08 Jul 2008 12:33:37 PM UTC, original submission:

This patch fixes a problem in the OpenAL-handling code where we would delete a sample but not remove it from the queue of playing samples. When we not much later update the sound system, we get AL_INVALID_NAME and workarounds set in to correct the issue.

While this is probably not related to the memory corruption issue from the use of playlists, getting this noise of out of the system would be a good thing.

Per I. Mathisen <per>
Project Administrator

 

Attached Files
file #4537:  sound2.diff added by per (7kB - text/x-patch)
file #4536:  soundfix2.diff added by per (1kB - text/x-patch)
file #4535:  soundfix.diff added by per (1kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by muggenhor (Updated the item)
  • -unavailable- added by per (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 08 Jul 2008 06:16:14 PM UTCperStatusDone=>Works For Me
      Open/ClosedClosed=>Open
    Tue 08 Jul 2008 06:16:13 PM UTCperAttached File-=>Added sound2.diff, #4537
    Tue 08 Jul 2008 04:49:36 PM UTCmuggenhorStatusWorks For Me=>Done
      Open/ClosedOpen=>Closed
    Tue 08 Jul 2008 02:42:40 PM UTCperAttached File-=>Added soundfix2.diff, #4536
    Tue 08 Jul 2008 12:33:37 PM UTCperAttached File-=>Added soundfix.diff, #4535
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup