patchBattle for Wesnoth - Patches: patch #3215, Implementation of duration= in...

 
 
Show feedback again

patch #3215: Implementation of duration= in [message]

Submitted by:  Thomas Martinet <hankerspace>
Submitted on:  Wed 28 Mar 2012 07:52:17 PM UTC  
 
Priority: 5 - NormalStatus: In Progress
Privacy: PublicAssigned to: Mark de Wever <mordante>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 18 Apr 2012 08:59:25 AM UTC, comment #8:

Updated as auto close timeout final
Using lexical_cast_default and with good indentation.

(file #15596)

Thomas Martinet <hankerspace>
Tue 03 Apr 2012 09:59:12 AM UTC, comment #7:

Updated as Auto_Close_Timeout

(file #15506)

Thomas Martinet <hankerspace>
Mon 02 Apr 2012 05:09:21 PM UTC, comment #6:

Can you summarize which modifications left ?
Maybe the underscores ?

Thomas Martinet <hankerspace>
Mon 02 Apr 2012 04:55:35 PM UTC, comment #5:

Any progress regarding what we discussed on IRC?

Mark de Wever <mordante>
Project MemberIn charge of this item.
Sat 31 Mar 2012 06:28:05 PM UTC, comment #4:

Updated with MaxDuration1.patch

(file #15487)

Thomas Martinet <hankerspace>
Fri 30 Mar 2012 09:00:19 PM UTC, comment #3:

I've use copy and paste to respect the indentation and rename my variable. I note your advice. Thanks.

(file #15470)

Thomas Martinet <hankerspace>
Fri 30 Mar 2012 06:35:56 PM UTC, comment #2:

Some notes on coding conventions:
We like to have code written in a more-or-less same style.

non-public class member variables (and only them) should end in underscore (like 'max_duration_' when it is a class variables, and just 'max_duration' when it is a local variable or a method parameter)

So, use max_duration_ only when it is a class variable, and never use _max_duration

Also, watch the spacing - use only tabs, not spaces, to indent C++ code in wesnoth.

Iurii Chernyi <crab>
Project Member
Thu 29 Mar 2012 10:37:55 AM UTC, comment #1:

Updated with shadowm and anonymissimus advises :
-use lexical_cast instead atoi()
-use the "max_" prefix for variables

(file #15448)

Thomas Martinet <hankerspace>
Wed 28 Mar 2012 07:52:17 PM UTC, original submission:

An implementation of duration, in frames. When a duration=X is specified in [message], the message will automatically dissapear after X frames. If the player click or press spacebar, the message can be skipped earlier.

Was requested here : https://gna.org/bugs/?func=detailitem&item_id=18483

Thomas Martinet <hankerspace>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15487:  MaxDuration1.patch added by hankerspace (3kB - application/octet-stream - Last update)
file #15473:  MaxDuration.patch added by hankerspace (4kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mordante (Posted a comment)
  • -unavailable- added by crab (Posted a comment)
  • -unavailable- added by hankerspace (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Apr 2012 08:59:25 AM UTChankerspaceAttached File-=>Added Auto close timeout final.patch, #15596
    Tue 03 Apr 2012 09:59:12 AM UTChankerspaceAttached File-=>Added Auto_Close_Timeout.patch, #15506
    Mon 02 Apr 2012 04:55:35 PM UTCmordanteStatusNone=>In Progress
      Assigned toNone=>mordante
    Sat 31 Mar 2012 06:28:05 PM UTChankerspaceAttached File-=>Added MaxDuration1.patch, #15487
    Fri 30 Mar 2012 10:13:02 PM UTChankerspaceAttached File-=>Added MaxDuration.patch, #15473
    Fri 30 Mar 2012 09:13:06 PM UTChankerspaceAttached File-=>Added ImplementationDurationFinal (1).patch, #15471
    Fri 30 Mar 2012 09:00:19 PM UTChankerspaceAttached File-=>Added ImplementationDurationFinal.patch, #15470
    Thu 29 Mar 2012 10:37:55 AM UTChankerspaceAttached File-=>Added ImplementationDurationUPDATED.patch, #15448
    Wed 28 Mar 2012 07:52:17 PM UTChankerspaceAttached File-=>Added ImplementationDuration.patch, #15444
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup