( Jump to the original submission )
Wed 18 Apr 2012 08:59:25 AM UTC, comment #8: Updated as auto close timeout final
Using lexical_cast_default and with good indentation.
(file #15596 )
Tue 03 Apr 2012 09:59:12 AM UTC, comment #7: Updated as Auto_Close_Timeout
(file #15506 )
Mon 02 Apr 2012 05:09:21 PM UTC, comment #6: Can you summarize which modifications left ?
Maybe the underscores ?
Mon 02 Apr 2012 04:55:35 PM UTC, comment #5: Any progress regarding what we discussed on IRC?
Sat 31 Mar 2012 06:28:05 PM UTC, comment #4: Updated with MaxDuration1.patch
(file #15487 )
Fri 30 Mar 2012 09:00:19 PM UTC, comment #3: I've use copy and paste to respect the indentation and rename my variable. I note your advice. Thanks.
(file #15470 )
Fri 30 Mar 2012 06:35:56 PM UTC, comment #2: Some notes on coding conventions:
We like to have code written in a more-or-less same style.
non-public class member variables (and only them) should end in underscore (like 'max_duration_' when it is a class variables, and just 'max_duration' when it is a local variable or a method parameter)
So, use max_duration_ only when it is a class variable, and never use _max_duration
Also, watch the spacing - use only tabs, not spaces, to indent C++ code in wesnoth.
Thu 29 Mar 2012 10:37:55 AM UTC, comment #1: Updated with shadowm and anonymissimus advises :
-use lexical_cast instead atoi()
-use the "max_" prefix for variables
(file #15448 )
Wed 28 Mar 2012 07:52:17 PM UTC, original submission: An implementation of duration, in frames. When a duration=X is specified in [message], the message will automatically dissapear after X frames. If the player click or press spacebar, the message can be skipped earlier.
Was requested here : https://gna.org/bugs/?func=detailitem&item_id=18483
(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 10 latest changes.
Date
Changed By
Updated Field
Previous Value
=>
Replaced By
Wed 18 Apr 2012 08:59:25 AM UTC hankerspace Attached File - Added Auto close timeout final.patch, #15596
Tue 03 Apr 2012 09:59:12 AM UTC hankerspace Attached File - Added Auto_Close_Timeout.patch, #15506
Mon 02 Apr 2012 04:55:35 PM UTC mordante Status None In Progress
Assigned to None mordante
Sat 31 Mar 2012 06:28:05 PM UTC hankerspace Attached File - Added MaxDuration1.patch, #15487
Fri 30 Mar 2012 10:13:02 PM UTC hankerspace Attached File - Added MaxDuration.patch, #15473
Fri 30 Mar 2012 09:13:06 PM UTC hankerspace Attached File - Added ImplementationDurationFinal (1).patch, #15471
Fri 30 Mar 2012 09:00:19 PM UTC hankerspace Attached File - Added ImplementationDurationFinal.patch, #15470
Thu 29 Mar 2012 10:37:55 AM UTC hankerspace Attached File - Added ImplementationDurationUPDATED.patch, #15448
Wed 28 Mar 2012 07:52:17 PM UTC hankerspace Attached File - Added ImplementationDuration.patch, #15444