( Jump to the original submission )
Wed 03 Oct 2012 05:03:01 PM UTC, SVN revision 55477: Apply patch #3360 for 1.10
(Browse SVN revision 55477 )
Mon 01 Oct 2012 11:19:26 AM UTC, SVN revision 55454: Apply patch #3360 . Fixes bug #19862 and bug #16220
(Browse SVN revision 55454 )
Sun 30 Sep 2012 05:51:44 PM UTC, comment #5: It apparently does.
Since no one grabbed this patch in the last two months I think I can safely assign it to myself.
Sat 29 Sep 2012 01:17:20 AM UTC, comment #4: Would be worth checking to see if this patch also addresses bug bug #16220
Sat 07 Jul 2012 02:40:34 PM UTC, comment #3: Replaced all occurrences of the foreach macro with BOOST_FOREACH.
(file #16004 )
Sat 07 Jul 2012 09:34:00 AM UTC, comment #2: Issue solved. Moved some code around in the change control stuff in turn_info::process_network_data() so that it runs even if make_human() was called on the affected team before and added a change_controller() call in the switch statement, under the "Replace with local player" case (I wonder why it wasn't there in the first place).
(file #16000 )
Fri 06 Jul 2012 08:29:59 PM UTC, comment #1: The patch has an issue, see irc discussion #wesnoth-dev 06.07.2012 20:10 - 20:49
Tue 03 Jul 2012 02:34:24 PM UTC, original submission: This patch fixes #19862 and a bunch of other (possibly not yet spotted) bugs related to transferring control of sides in mp games.
The bugs:
droiding your side make you become an observer
undroiding your side during the turn of someone else results in your messages appearing in that side's color on your client (a.k.a. bug #19862 )
when passing control of a side to a player the gui isn't properly updated
droiding/undroiding a side during that side's turn would make the actions of that side visible for everyone for that turn
And the respective fixes:
modified is_observer() to return true only if there're no human or human_ai sides
solved as a side effect of fix 1
added the appropriate function calls in turn_info::process_network_data()
removed unnecessary update_gui_to_player() call at playmp_controller.cpp:492
(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 7 latest changes.
Date
Changed By
Updated Field
Previous Value
=>
Replaced By
Thu 14 Mar 2013 07:47:48 AM UTC shadowmaster Open/Closed Open Closed
Mon 01 Oct 2012 11:22:06 AM UTC lipk Status In Progress Done
Sun 30 Sep 2012 05:51:44 PM UTC lipk Status None In Progress
Assigned to None lipk
Sat 07 Jul 2012 02:40:34 PM UTC lipk Attached File - Added change_control_fix.diff, #16004
Sat 07 Jul 2012 09:34:00 AM UTC lipk Attached File - Added change_control_fix.diff, #16000
Tue 03 Jul 2012 02:34:24 PM UTC lipk Attached File - Added change_control_fix.diff, #15964