patchBattle for Wesnoth - Patches: patch #3537, MP campaign: new observers get OOS...

 
 
Show feedback again

patch #3537: MP campaign: new observers get OOS on second scenario (bug #20217)

Submitted by:  FAAB <faabumc>
Submitted on:  Mon 08 Oct 2012 05:24:35 AM UTC  
 
Priority: 5 - NormalStatus: Done
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 18 Oct 2012 07:32:21 PM UTC, SVN revision 55551:

Apply patch #3537 by faabumc, which fixes second-scenario observer OOS (bug #20217)

(Browse SVN revision 55551)

Alexander van Gessel <ai0867>
Project Member
Mon 08 Oct 2012 05:24:35 AM UTC, original submission:

This is a proposal to fix bug #20217.

In the referenced bug report, we identify that two different methods are used to cast the random seed from string to integer.
The method used in src/multiplayer_ui.cpp is keeping only the first digit of the integer.

This patch is implementing the same casting than in src/savegame.cpp ([].to_int(42)). The table below is showing the seed for different connections at different stages of the game:

We see that after applying the patch the seed is never rounded to one digit and that the seed for the host and observers are identical at all time.

Given that this patch changes the way the host is casting the seed from WML, the resulting binary is not compatile with the current ones. For this reason the patch should only be applied on trunk.

FAAB <faabumc>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16671:  ui.diff added by faabumc (1kB - text/x-patch - Patch file against trunk at rev 55528)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by ai0867 (Updated the item)
  • -unavailable- added by faabumc (Submitted the item)
  • -unavailable- added by faabumc
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 14 Mar 2013 07:48:03 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Thu 18 Oct 2012 07:34:14 PM UTCai0867StatusNone=>Done
    Mon 08 Oct 2012 05:24:35 AM UTCfaabumcAttached File-=>Added ui.diff, #16671
      Carbon-Copy-=>Added natasiel
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup