patchBattle for Wesnoth - Patches: patch #3774, Death Animation WML fix for new...

 
 
Show feedback again

patch #3774: Death Animation WML fix for new syntax changes

Submitted by:  David Mikos <coffee>
Submitted on:  Sat 09 Mar 2013 02:32:19 AM UTC  
 
Priority: 3 - LowStatus: Done
Privacy: PublicAssigned to: Jérémy Rosen <boucman>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 10 Mar 2013 08:52:43 AM UTC, SVN revision 56469:

apply patch #3774 by coffee fix bug #20601

(Browse SVN revision 56469)

Jérémy Rosen <boucman>
Project MemberIn charge of this item.
Sat 09 Mar 2013 10:59:14 PM UTC, comment #1:

Just a minor update to the patch for those other functions where the timing was incorrectly specified (attck frame where unit is killed).

(file #17414)

David Mikos <coffee>
Project Member
Sat 09 Mar 2013 02:32:19 AM UTC, original submission:

Attached is a patch to fix the last frame of the death animation for when a sequence of images is used in a frame to describe the death animation.

Problem was that the duration parameter was setting current time to 0 for the last frame, so it needed to be fixed anyways. There are other occurrences too for other types of animations with this wrong specification of time, so a follow up patch might be needed for other types of animation sequences specified in unit_animations.cpp "add_anims".

Should fix https://gna.org/bugs/?20601

David Mikos <coffee>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17410:  2013.03.09_death_animation_bug_fix added by coffee (2kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by boucman (Updated the item)
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by coffee (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Aug 2013 12:43:19 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 10 Mar 2013 08:53:06 AM UTCboucmanStatusNone=>Done
    Sat 09 Mar 2013 10:59:14 PM UTCcoffeeAttached File-=>Added 2013.03.10_death_and_attack_end_animation_bug_fix.patch, #17414
    Sat 09 Mar 2013 09:22:12 AM UTCshadowmasterAssigned toNone=>boucman
    Sat 09 Mar 2013 02:32:19 AM UTCcoffeeAttached File-=>Added 2013.03.09_death_animation_bug_fix, #17410
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup