patchBattle for Wesnoth - Patches: patch #3784, SOUND:HIT_AND_MISS simplification...

 
 
Show feedback again

patch #3784: SOUND:HIT_AND_MISS simplification for unitWML

Submitted by:  David Mikos <coffee>
Submitted on:  Sat 16 Mar 2013 10:35:52 PM UTC  
 
Priority: 4Status: Done
Privacy: PublicAssigned to: Jérémy Rosen <boucman>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 17 Mar 2013 10:15:31 AM UTC, comment #1:

looks good to me, feel free to apply

Jérémy Rosen <boucman>
Project MemberIn charge of this item.
Sat 16 Mar 2013 10:35:52 PM UTC, original submission:

Here's (with some luck) the last of the massive all unit animation WML simplification patches.

This one makes no C++ changes. Instead the reductions come from using the SOUND:HIT_AND_MISS macro and defining a very similar new SOUND:HIT macro and applying these throughout to all default units.

Thse macros take in an absolute starting times. With the simplification in unit animation WML, do you think this obvious enough?

David Mikos <coffee>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by boucman (Posted a comment)
  • -unavailable- added by coffee (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Aug 2013 12:43:08 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Thu 21 Mar 2013 09:14:11 AM UTCcoffeeStatusNeed Info=>Done
    Sat 16 Mar 2013 10:35:52 PM UTCcoffeeAttached File-=>Added 2013.03.17-HIT_AND_MISS_unit_animation_WML_simplification.patch, #17442
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup