patchBattle for Wesnoth - Patches: patch #3834, Fixed bug #20381: Change...

 
 
Show feedback again

patch #3834: Fixed bug #20381: Change Difficulty checkbox gets disabled if can't change difficulty

Submitted by:  Maxim Biro <nurupo>
Submitted on:  Fri 05 Apr 2013 03:46:05 AM UTC  
 
Priority: 3 - LowStatus: Done
Privacy: PublicAssigned to: Ignacio R. Morelle <shadowmaster>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 06 Apr 2013 03:38:46 AM UTC, comment #2:

Applied and committed version 2 (file #17682) to Git, thanks.

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.
Sat 06 Apr 2013 03:38:02 AM UTC, comment #1:

It appears that the "loading game has >0 turns done" is a false condition for start-of-scenario save files, for which this patch is. The start-of-scenario save files don't contain any information about how many turns were made.

This is taken into account in gui1_bugfix20381_2.patch.

That is, gui1_bugfix20381.patch is invalid.

Maxim Biro <nurupo>
Fri 05 Apr 2013 03:46:05 AM UTC, original submission:

"Change Difficulty" checkbox in "Load Game" dialog gets disabled if change in difficulty of a loading game won't take effect — the loading game has >0 turns done.

The patch fixes only GUI1, which is currently the default for "Load Game" dialog.

Maxim Biro <nurupo>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17682:  gui1_bugfix20381_2.patch added by nurupo (5kB - application/octet-stream - fix of the bugfix)
file #17679:  gui1_bugfix20381.patch added by nurupo (5kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by nurupo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Aug 2013 12:42:23 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 06 Apr 2013 03:38:46 AM UTCshadowmasterStatusNone=>Done
    Sat 06 Apr 2013 02:59:29 AM UTCnurupoAttached File-=>Added gui1_bugfix20381_2.patch, #17682
    Sat 06 Apr 2013 02:14:07 AM UTCshadowmasterAssigned toNone=>shadowmaster
    Fri 05 Apr 2013 03:46:06 AM UTCnurupoAttached File-=>Added gui1_bugfix20381.patch, #17679
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup