patchBattle for Wesnoth - Patches: patch #3844, Fixed bug #20592: Dialog window...

 
 
Show feedback again

patch #3844: Fixed bug #20592: Dialog window position in the widescreen theme

Submitted by:  Andrius Silinskas <thunderstruck>
Submitted on:  Thu 11 Apr 2013 07:39:22 AM UTC  
 
Priority: 3 - LowStatus: Done
Privacy: PublicAssigned to: Mark de Wever <mordante>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 29 Apr 2013 06:51:26 PM UTC, comment #2:

I made some minor fixes as discussed on IRC and will commit it soon. (At the moment I can't test it on master.)

Mark de Wever <mordante>
Project MemberIn charge of this item.
Sat 20 Apr 2013 08:24:02 PM UTC, comment #1:

discussed on IRC:
<mordante> thunderstruck, why did you call the variable gamemap_width_offset?
<thunderstruck> mordante, hmm.. Would gamemap_x_offset would be better?
<mordante> thunderstruck, yes
<mordante> thunderstruck, please also have a look at src/gui/auxiliary/canvas.cpp:366
<mordante> thunderstruck, and I think the bug is player visible so also please an update to the player's changelog
<thunderstruck> mordante, ok. No problem.
<mordante> other then that it looks fine to me
<thunderstruck> mordante, I'll fix it tomorrow.

Mark de Wever <mordante>
Project MemberIn charge of this item.
Thu 11 Apr 2013 07:39:22 AM UTC, original submission:

Dialog (wml_message.cfg) is now shifted by the distance between the left edge of the screen and the game map.

Andrius Silinskas <thunderstruck>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17794:  wml_message2.patch added by thunderstruck (5kB - text/x-patch - Minor fixes according to the mordante's suggestions.)
file #17737:  wml_message.patch added by thunderstruck (4kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by mordante (Updated the item)
  • -unavailable- added by thunderstruck (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Aug 2013 12:42:06 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Mon 29 Apr 2013 06:51:26 PM UTCmordanteStatusIn Progress=>Done
    Sun 21 Apr 2013 10:08:42 PM UTCthunderstruckAttached File-=>Added wml_message2.patch, #17794
    Sat 20 Apr 2013 08:24:02 PM UTCmordanteStatusNone=>In Progress
    Sat 13 Apr 2013 07:29:32 PM UTCmordanteAssigned toNone=>mordante
    Thu 11 Apr 2013 07:39:22 AM UTCthunderstruckAttached File-=>Added wml_message.patch, #17737
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup