patchFreeciv - Patches: patch #4407, Move requirement range/survives...

Show feedback again

patch #4407: Move requirement range/survives sanity checking from req_from_str() to rssanity.c

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 04 Jan 2014 07:24:19 PM UTC  
Category: generalPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat 04 Jan 2014 07:24:19 PM UTC, original submission:

Currently, req_from_str() does some sanity checking of requirements when parsing them: it checks validity of ranges for requirements, and (after patch #4396) the 'survives' field.

cazfi notes in bug #21418 comment 1:

> On a general note, we need to be moving all possible sanity
> checks to sanity_check_ruleset_data() which freeciv-ruledit then
> can use to check ruleset being modified.

req_from_str() should be reduced to checking the syntax of individual fields, and semantic checking of ranges vs types etc moved to rssanity.c (probably building on bug #21418).

(I think this will lose us reporting of which filename/section is at fault, but it can't be helped.)

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


   bug dependencies.

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Jan 2016 07:31:01 AM UTCcazfiCategoryNone=>general
      Planned Release2.6.0=>2.6.0, 3.0.0
    Sat 04 Jan 2014 07:24:42 PM UTCjtnDependencies-=>Depends on bugs #21418
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup