helpVbrfix - Support: sr #1379, [PATCH] Info support

 
 
Show feedback again

sr #1379: [PATCH] Info support

Submitted by:  J. Alexander Treuman <jat>
Submitted on:  Wed 29 Nov 2006 06:32:39 AM UTC  
 
Category: FixerPriority: 5 - Normal
Severity: 1 - WishStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: 
Operating System: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 20 May 2009 12:14:14 PM UTC, comment #1:

Hi,

I fixed the patch to the current subversion version
and added a line to avoid adding info-headers to CBR files.

Anonymous
Wed 29 Nov 2006 06:32:39 AM UTC, original submission:

This patch adds support for "Info" as magic for Xing headers. Info headers are found on CBR MP3s (mostly because they're needed for LAME headers), and are otherwise identical to Xing headers. This will detect such headers, as well as add them to CBR MP3s that are missing them (provided skipping CBR MP3s isn't enabled).

I'm not entirely sure if the changes to VbrFixer.cpp are technically correct, so at the very least they should be thoroughly reviewed. Additionally it may be desirable to change it to only fix Info tags, not add them.

J. Alexander Treuman <jat>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #5793:  vbrfix-info-support-fixed.patch added by None (5kB - text/x-patch - fixed the patch to the current subversion version, and added a line to avoid adding info-headers to CBR files)
file #1623:  vbrfix-r99-info-support.patch added by jat (5kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jat (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 May 2009 12:12:50 PM UTCNoneAttached File-=>Added vbrfix-info-support-fixed.patch, #5793
    Wed 29 Nov 2006 06:37:30 AM UTCjatCarbon-CopyRemoved jat=>-
    Wed 29 Nov 2006 06:32:39 AM UTCjatAttached File-=>Added vbrfix-r99-info-support.patch, #1623
      Carbon-Copy-=>Added jat
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup