helpSavane - Support: sr #1640, svn commits depend on perl-suid

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

sr #1640: svn commits depend on perl-suid

Submitted by:  Rudy Gevaert <rudy>
Submitted on:  Sun 03 Jun 2007 12:26:57 PM UTC  
 
Category: Installation/ConfigurationPriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 

(Jump to the original submission Jump to the original submission)

Mon 04 Jun 2007 08:08:02 AM UTC, comment #7:

please see bug #9273

Rudy Gevaert <rudy>
Project Member
Mon 04 Jun 2007 08:01:27 AM UTC, comment #6:

Please, Rudy, post a bug report.

Best Regards,

Mathieu Roy <yeupou>
Project Administrator
Mon 04 Jun 2007 07:18:19 AM UTC, comment #5:

I have found this error too.

I'm using the option 'root_as_url_component = 0' in my viewcvs.conf file. That means that my revision pages (that are linked to) look like:
http://svn.savannah.ugent.be/?root=testproject&rev=13&view=rev

The link the latest savane produces is:
http://svn.savannah.ugent.be/?root=testproject?rev=13&view=rev

It puts an ? before rev instead of a &.

In the code I found:

$out .= '<p>(<a href="'.$svn_link.'?rev='.$entry['revision'].'&amp;view=rev">'.sprintf(_("Browse SVN revision %s"), $entry['revision']).'</a>)</p>';

So changing it to:

$out .= '<p>(<a href="'.$svn_link.'&amp;rev='.$entry['revision'].'&amp;view=rev">'.sprintf(_("Browse SVN revision %s"), $entry['revision']).'</a>)</p>';

fixes it.

The underlying problem is (I think) that savane assumes that all links to the viewcvs front end contain the project name as a directory. For example:
http://svn.gna.org/viewcvs/savane/?rev=6443&view=rev

In my case that doesn't work.

We should/could check $svn_link. If there is already an ? in that string we need to use an &, if it doesn't we should use an &. If this is ok I can commit a fix like that to the trunk.

Rudy Gevaert <rudy>
Project Member
Sun 03 Jun 2007 09:03:31 PM UTC, comment #4:

As another side note the links in my frontend point to ViewCVS Exception pages. I'll look in to this the comming week.

Rudy Gevaert <rudy>
Project Member
Sun 03 Jun 2007 08:58:33 PM UTC, comment #3:

I fixed it. I could debug it by adding '2>/tmp/file' to my post-commit file. It then showed in that same file:
Can't do setuid (cannot exec sperl).

Installing perl-suid fixed my problem.

This SR may be closed.

As a side note you could add perl-suid to the debian control file.

Rudy Gevaert <rudy>
Project Member
Sun 03 Jun 2007 12:27:58 PM UTC, comment #2:

Did you try a direct test by running your command with $REPOS and $REV set manually?

/usr/local/bin/sv_extra_svn_postcommit_brigde -t "$REPOS" -r "$REV" -p testproject -d

Mathieu Roy <yeupou>
Project Administrator
Sun 03 Jun 2007 12:26:57 PM UTC, comment #1:

This item has been reassigned from the project Gna! Administration support tracker to your tracker.

The original report is still available at support #1627

Following are the information included in the original report:

[field #0] Item ID: 1627
[field #1] Group ID: 101
[field #2] Open/Closed: Open
[field #3] Severity: 3 - Normal
[field #4] Privacy: Public
[field #8] : Unknown support Field Display Type
[field #9] Category: SCM: Subversion Repositories
[field #10] Submitted by: rudy
[field #11] Assigned to: None
[field #12] Submitted on: vendredi 25.05.2007 à 14:38
[field #13] Summary: SVN commits doesn t annotate items
[field #14] Original Submission: Hi,

I ve installed the Savane 3.0, but can t get
/usr/local/bin/sv_extra_svn_postcommit_brigde to work correctly.

groen:/savannah/svn/source/testproject/hooks# ls -l /usr/local/bin/sv_extra_svn_postcommit_brigde
-rwsr-sr-x 1 root staff 8042 May 25 10:20 /usr/local/bin/sv_extra_svn_postcommit_brigde

my post-commit file:
groen:/savannah/svn/source/testproject/hooks# grep -v \# post-commit

REPOS="$1"
REV="$2"

/usr/local/bin/sv_extra_svn_postcommit_brigde -t "$REPOS" -r "$REV" -p testproject -d

permissions:
groen:/savannah/svn/source/testproject/hooks# ls -l post-commit
-rwxrwxr-x 1 root root 1384 May 25 14:25 post-commit

When doing the svn commit my item doesn t get annotated, nor do I see any debugging info.

If I could get some debugging info I at least could start looking somewhere :)

Thanks in advance,

Rudy

[field #16] Item Group: None
[field #17] Status: Confirmed
[field #18] Component Version: None
[field #19] Operating System: GNU/Linux
[field #20] Reproducibility: None
[field #21] Size (loc): None
[field #22] Fixed Release: None
[field #23] Planned Release: None
[field #24] Effort: 0.00
[field #28] Priority: 5 - Normal
[field #31] Percent Complete: 0%
[field #33] Release: None
[field #58] Custom Select Box #1: None
[field #59] Custom Select Box #2: None
[field #60] Custom Select Box #3: None
[field #61] Custom Select Box #4: None
[field #62] Custom Select Box #5: None
[field #63] Custom Select Box #6: None
[field #64] Custom Select Box #7: None
[field #65] Custom Select Box #8: None
[field #66] Custom Select Box #9: None
[field #67] Custom Select Box #10: None

Mathieu Roy <yeupou>
Project Administrator
Sun 03 Jun 2007 12:26:57 PM UTC, original submission:

Hi,

I've installed the Savane 3.0, but can't get
/usr/local/bin/sv_extra_svn_postcommit_brigde to work correctly.

groen:/savannah/svn/source/testproject/hooks# ls -l /usr/local/bin/sv_extra_svn_postcommit_brigde
-rwsr-sr-x 1 root staff 8042 May 25 10:20 /usr/local/bin/sv_extra_svn_postcommit_brigde

my post-commit file:
groen:/savannah/svn/source/testproject/hooks# grep -v \# post-commit

REPOS="$1"
REV="$2"

/usr/local/bin/sv_extra_svn_postcommit_brigde -t "$REPOS" -r "$REV" -p testproject -d

permissions:
groen:/savannah/svn/source/testproject/hooks# ls -l post-commit
-rwxrwxr-x 1 root root 1384 May 25 14:25 post-commit

When doing the svn commit my item doesn't get annotated, nor do I see any debugging info.

If I could get some debugging info I at least could start looking somewhere :)

Thanks in advance,

Rudy

Rudy Gevaert <rudy>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yeupou (Updated the item)
  • -unavailable- added by rudy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 04 Jun 2007 08:08:02 AM UTCrudySummarySVN commits doesn't annotate items correct if root_as_url_component = 0=>svn commits depend on perl-suid
    Mon 04 Jun 2007 07:18:19 AM UTCrudyStatusDone=>Need Info
      Open/ClosedClosed=>Open
      SummarySVN commits doesn't annotate items (correct)=>SVN commits doesn't annotate items correct if root_as_url_component = 0
    Mon 04 Jun 2007 06:54:07 AM UTCyeupouStatusNeed Info=>Done
      Open/Closed-Automatic update due to transitions settings-=>Closed
    Sun 03 Jun 2007 09:03:31 PM UTCrudySummarySVN commits doesn't annotate items=>SVN commits doesn't annotate items (correct)
    Sun 03 Jun 2007 12:27:58 PM UTCyeupouCategoryNone=>Installation/Configuration
      StatusNone=>Need Info
    Sun 03 Jun 2007 12:26:57 PM UTCyeupouReassign itemGna! Administration, sr #1627=>Savane, sr #1640
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup