helppokersource - Support: sr #2262, Reassigned to another tracker...

 
 
Show feedback again

sr #2262: Reassigned to another tracker [was: PacketPokerPlayerInfo() needs locale value ? PokerService.getPlayerInfo() refers to it]

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Wed 11 Feb 2009 10:51:51 PM UTC  
 
Category: poker-networkPriority: 5 - Normal
Severity: 2 - MinorStatus: Confirmed
Privacy: PublicAssigned to: None
Open/Closed: ClosedOperating System: GNU/Linux
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 24 Jun 2009 05:42:28 PM UTC, comment #3:

THIS ITEM WAS REASSIGNED TO BUG #13776.

Please, do not post any new comments to this item.


Bradley M. Kuhn <bkuhn>
Project Administrator
Sat 04 Apr 2009 03:51:52 PM UTC, SVN revision 5604:

Merged coverage-poker-network branch into trunk for 100% pokerservice.py coverage:
* Wrote numerous tests in test-pokerservice.py.in
* raise NotImplementedError() in getArguments() and maps2result() in
PokerXML. Closes sr #2274
* Created test-pokerservice-load.py.in, which meta-tests various loading
conditions of pokerservice.py
* Comments to note failed insert should return None in
PokerService.createTable(). See sr #2273
* Made notes about PokerPlayerInfoLocale in pokerservice.py and
pokerpackets.py, see sr #2262
* run.in now has pokerservice.py listed for 100% coverage!
* test-pokerservice-load.py.in and test-pokerservice-load.py call each
other via compile-command variable.
* Added test-pokerservice-load.py.in to configure.ac
* Minor fix to a comment in test-pokeravatar.py.in
* Detailed ChangeLog entries for what was done.

(Browse SVN revision 5604)

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed 11 Feb 2009 10:58:14 PM UTC, SVN revision 5514:

Wrote test to cover default caes of PokerService.getPlayerInfo().
Discovered an odd thing while doing that: locale argument is given to
PacketPokerPlayerInfo() but is actually ignored. Note sure why that is
there, so I opened sr #2262 and made FIXME notes in the code.

(Browse SVN revision 5514)

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed 11 Feb 2009 10:51:51 PM UTC, original submission:

THIS ITEM WAS REASSIGNED TO BUG #13776.

I just noticed that when I made the locale changes, I added a locale = setting in PokerService.getPlayerInfo() creation of the dummy info packet.

It's not clear to me that this was needed at all, and I don't think anything relies on it, but I've left it in just in case there was a reason.

At some point, someone should investigate why this is done here, and if it was just an error or not. I was in the middle of doing some test coverage when I discovered it, so I just created this ticket and marked the places in the code that are relevant with FIXME_PokerPlayerInfoLocale

Bradley M. Kuhn <bkuhn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 24 Jun 2009 05:42:28 PM UTCbkuhnReassign Itempokersource, sr #2262=>pokersource, bug #13776
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup